Hi Andrew,
Andrew Ziem wrote:
These test case sensitivity in setupapi string tables, and all the parts I modified pass on Microsoft's 98 and XP. As this is my first Wine patch, comments are especially welcome.
For tests that don't pass in wine, please enclose them in todo_wine { }, so that the Wine test suite doesn't fail.
Index: stringtable.c
RCS file: /home/wine/wine/dlls/setupapi/tests/stringtable.c,v retrieving revision 1.2 diff -u -r1.2 stringtable.c --- stringtable.c 23 Sep 2005 10:09:47 -0000 1.2 +++ stringtable.c 1 May 2006 05:59:55 -0000
Please do the diff in the "wine" directory like this:
cvs diff dlls/setupapi/tests/stringtable
The rest of the patch looks OK, but it didn't apply to my tree, so I haven't tested it.
bash-3.00$ cd dlls/setupapi/tests/ bash-3.00$ patch -p0 --dry-run < ../../../x.eml patching file stringtable.c Hunk #3 FAILED at 120. 1 out of 3 hunks FAILED -- saving rejects to file stringtable.c.rej
Mike
Mike McCormack wrote:
Hi Andrew,
Andrew Ziem wrote:
These test case sensitivity in setupapi string tables, and all the parts I modified pass on Microsoft's 98 and XP. As this is my first Wine patch, comments are especially welcome.
For tests that don't pass in wine, please enclose them in todo_wine { }, so that the Wine test suite doesn't fail.
Everything passes in WINE, 2000, and XP. However, in 98 one test fails:
result=lstrcmpiW(string, string3); ok(result!=0,"StringID %p matches requested StringID %p\n",string,string3);
Index: stringtable.c
RCS file: /home/wine/wine/dlls/setupapi/tests/stringtable.c,v retrieving revision 1.2 diff -u -r1.2 stringtable.c --- stringtable.c 23 Sep 2005 10:09:47 -0000 1.2 +++ stringtable.c 1 May 2006 05:59:55 -0000
Please do the diff in the "wine" directory like this:
cvs diff dlls/setupapi/tests/stringtable
OK. Thanks for the tip.
Andrew
-
Andrew Ziem -
Mike McCormack