Pegasus Mail 4.02 ('Silver' App)

[Rick Romero]

Hey all, I'm currently testing out Pegasus Mail, and I've noticed three
issues that I would like to help with debugging.

One issue I've found is a window refesh issue.

By default Pegasus Mail will minimize to the system tray, not the
taskbar.
This doesn't work.  Once you've minimized Pmail, or merely changed to
another virtual desktop, the app window no longer responds. (the default
ison - must turn off).  With the window open, Pegasus Mail IS on the
taskbar, only the option is checked for that to disappear if the app is
minimized.

After you turn the 'taskbar' setting back on, everything works fine.

The second issue, I've noticed that double-clicking the system tray icon
does notrestore Pegasus Mail.  I can minimize it so it appears both on
the taskbar and the system tray, but I can't restore the application
from the system tray icon (though I can from the taskbar).

You CAN right-click, and get a menu.  The two menu options sort of work:
    New Mail information, opens a new window that has the number
     of new messages.  Works fine.

The third issue the the systray icon's 2nd menu item:
    Start a New Mail Message, does just that, but the window starts
          shrunk down. All you can see is the "Message(F8)" Tab
      of that window.  Once you resize the window, it appears 	  to work
fine.

I'm not sure if all these issues can be covered with one trace, let me
know what steps you want me to take to try and resolve these issues.

Thanks!

Rick

[Duane Clark]

Rick Romero wrote:
> Hey all, I'm currently testing out Pegasus Mail, and I've noticed three
> issues that I would like to help with debugging.
>
> ...
> The second issue, I've noticed that double-clicking the system tray icon
> does notrestore Pegasus Mail.  I can minimize it so it appears both on
> the taskbar and the system tray, but I can't restore the application
> from the system tray icon (though I can from the taskbar).

This can be fixed by this patch:
http://www.winehq.com/hypermail/wine-patches/2002/08/0094.html

Alexandre did not like the way I did that, so hopefully you can figure 
out the right fix :-)

[Rick Romero]

On Wed, 2002-11-20 at 10:59, Duane Clark wrote:
> Rick Romero wrote:
> > Hey all, I'm currently testing out Pegasus Mail, and I've noticed three
> > issues that I would like to help with debugging.
> >
> > ...
> > The second issue, I've noticed that double-clicking the system tray icon
> > does notrestore Pegasus Mail.  I can minimize it so it appears both on
> > the taskbar and the system tray, but I can't restore the application
> > from the system tray icon (though I can from the taskbar).
>
> This can be fixed by this patch:
> http://www.winehq.com/hypermail/wine-patches/2002/08/0094.html
>
> Alexandre did not like the way I did that, so hopefully you can figure 
> out the right fix :-)

I think you snipped the wrong issue :)

You patch fixed:
> By default Pegasus Mail will minimize to the system tray, not the
> taskbar.
> This doesn't work.  Once you've minimized Pmail, or merely changed to
> another virtual desktop, the app window no longer responds. (the 
> default is on - must turn off).  With the window open, Pegasus Mail IS
> on the taskbar, only the option is checked for that to disappear if
> the app is minimized.

I'm not sure what Alexandre may not have liked other than the extra
stuff that was in there, so I yanked out the extra things that didn't do
anything, and did a cvs diff -u .

How is this one?  (Should I have done it from wine/ instead ?)
>

[Duane Clark]

Rick Romero wrote:
> I'm not sure what Alexandre may not have liked other than the extra
> stuff that was in there, so I yanked out the extra things that didn't do
> anything, and did a cvs diff -u .
>
> How is this one?  (Should I have done it from wine/ instead ?)

Well, here was his comment at the time:
http://www.winehq.com/hypermail/wine-devel/2002/08/0360.html

[Dustin Navea]

----- Original Message -----
From: "Duane Clark" 
To: 
Sent: Wednesday, November 20, 2002 3:45 PM
Subject: Re: Pegasus Mail 4.02 ('Silver' App)
> Rick Romero wrote:
> > I'm not sure what Alexandre may not have liked other than the extra
> > stuff that was in there, so I yanked out the extra things that didn't do
> > anything, and did a cvs diff -u .
> >
> > How is this one?  (Should I have done it from wine/ instead ?)
>
> Well, here was his comment at the time:
> http://www.winehq.com/hypermail/wine-devel/2002/08/0360.html

<!-- Grabbed from hypermail -->
> Duane Clark  writes:
> > Unlike most other apps, when iconified fpga_editor triggers
> > X11DRV_ShowWindow() with a cmd==SW_HIDE, to hide the window. When
> > X11DRV_MapNotify() was subsequently called, it did nothing because
> > WS_VISIBLE was not set. This patch fixes that.
> >
> > I've been using this patch with everything I run for about 5 months now.
> >
> > Log message:
> >  Fix restoring of windows that were iconified with SW_HIDE.
>
> Well, SW_HIDE is supposed to hide the window, not iconify it, so we
> are not supposed to get a MapNotify at this point. What is probably
> missing is proper handling for hiding an iconified window.

It seems to me like Pegasus Mail is whats broken here.  The whole issue is
that SW_HIDE is called after the window is minimized, then when restored
SW_SHOW is not called because we arent supposed to receive a MapNotify, and
so it shows the window decoration (because the way the WM's handle windows)
and not the contents because they are still hidden.  But I guarantee that if
this was windows and it was doing this same thing, it wouldnt even show the
decoration because to windows the decoration and the contents are all the
same thing...

My point is that we should apply this hack until proper handling is
implemented, as I dont personally forsee anything getting messed up by it.
Maybe apply it but with an if to see if the window is hidden would be a
better patch, but thats about the only change I can see fit to it aside from
holding off until proper iconification is implemented, which would not be in
wine's best interests IMHO.

-Dustin

[Rick Romero]

On Wed, 2002-11-20 at 16:07, Dustin Navea wrote:
> ----- Original Message -----
> From: "Duane Clark" 
> To: 
> Sent: Wednesday, November 20, 2002 3:45 PM
> Subject: Re: Pegasus Mail 4.02 ('Silver' App)
> > Rick Romero wrote:
> > > I'm not sure what Alexandre may not have liked other than the extra
> > > stuff that was in there, so I yanked out the extra things that didn't do
> > > anything, and did a cvs diff -u .
> > >
> > > How is this one?  (Should I have done it from wine/ instead ?)
> >
> > Well, here was his comment at the time:
> > http://www.winehq.com/hypermail/wine-devel/2002/08/0360.html
>
> <!-- Grabbed from hypermail -->
> > Duane Clark  writes:
> > > Unlike most other apps, when iconified fpga_editor triggers
> > > X11DRV_ShowWindow() with a cmd==SW_HIDE, to hide the window. When
> > > X11DRV_MapNotify() was subsequently called, it did nothing because
> > > WS_VISIBLE was not set. This patch fixes that.
> > >
> > > I've been using this patch with everything I run for about 5 months now.
> > >
> > > Log message:
> > >  Fix restoring of windows that were iconified with SW_HIDE.
> >
> > Well, SW_HIDE is supposed to hide the window, not iconify it, so we
> > are not supposed to get a MapNotify at this point. What is probably
> > missing is proper handling for hiding an iconified window.
>
> It seems to me like Pegasus Mail is whats broken here.

I am far from an expert in OS function here, but I can say I've used
Pegasus Mail since Win95, right through to XP, used that option, and
never had an issue.
> The whole issue is
> that SW_HIDE is called after the window is minimized, then when restored
> SW_SHOW is not called because we arent supposed to receive a MapNotify, and
> so it shows the window decoration (because the way the WM's handle windows)
> and not the contents because they are still hidden.  But I guarantee that if
> this was windows and it was doing this same thing, it wouldnt even show the
> decoration because to windows the decoration and the contents are all the
> same thing...

If things are called out of order, it's been broken in Windows for that
long. :(   (or I'm misunderstanding what you're saying, which  is very
possible)
> My point is that we should apply this hack until proper handling is
> implemented, as I dont personally forsee anything getting messed up by it.
> Maybe apply it but with an if to see if the window is hidden would be a
> better patch, but thats about the only change I can see fit to it aside from
> holding off until proper iconification is implemented, which would not be in
> wine's best interests IMHO.

I don't like being the one to introduce a hack, so FWIW, Pegasus Mail
only requires the patch I attached.  If this works for Duane also,
excellent, I assume you'd want to keep the hack to a minimum.

Rick
> -Dustin

[Rick Romero]

On Wed, 2002-11-20 at 15:45, Duane Clark wrote:
> Rick Romero wrote:
> > I'm not sure what Alexandre may not have liked other than the extra
> > stuff that was in there, so I yanked out the extra things that didn't do
> > anything, and did a cvs diff -u .
> >
> > How is this one?  (Should I have done it from wine/ instead ?)
>
> Well, here was his comment at the time:
> http://www.winehq.com/hypermail/wine-devel/2002/08/0360.html

<text>Well, SW_HIDE is supposed to hide the window, not iconify it, so we
are not supposed to get a MapNotify at this point. What is probably
missing is proper handling for hiding an iconified window.
<endtext>

Dah.  I thought it just had gone uncommented.  I'll try and look ito
SW_HIDE then..

But in my case, I never attempt to minimize the window, merely selecting
the option to hide the window from the taskbar, and changing desktops
causes the application window to 'freeze'.

I wonder if maybe the patch could be reduced to:
-        SendMessageA( hwnd, WM_SHOWWINDOW, SW_RESTORE, 0 );
+        SendMessageA( hwnd, WM_SHOWWINDOW, SW_RESTORE, SW_SHOW );

I'll try and get that done in 15 minutes..

Rick
>

[Duane Clark]

Rick Romero wrote:
> ...
> I don't like being the one to introduce a hack, so FWIW, Pegasus Mail
> only requires the patch I attached.  If this works for Duane also,
> excellent, I assume you'd want to keep the hack to a minimum.

Unfortunately, fpga_editor is still broken with this patch, though it 
does make Pegasus work fine here too.