On 4/24/07, Yuval Fledel yuvalfl@gmail.com wrote:
+ if (LsaVersion != 0x10000)
What is 0x10000? If it's not defined in the SDK, then please use a #define to clarify what it means.
On 4/24/07, James Hawkins truiken@gmail.com wrote:
On 4/24/07, Yuval Fledel yuvalfl@gmail.com wrote:
- if (LsaVersion != 0x10000)
What is 0x10000? If it's not defined in the SDK, then please use a #define to clarify what it means.
Also, it would be nice to have some tests for these functions.
On 24/04/07, James Hawkins truiken@gmail.com wrote:
On 4/24/07, James Hawkins truiken@gmail.com wrote:
On 4/24/07, Yuval Fledel yuvalfl@gmail.com wrote:
- if (LsaVersion != 0x10000)
What is 0x10000? If it's not defined in the SDK, then please use a #define to clarify what it means.
Also, it would be nice to have some tests for these functions.
Wow, you're fast. I was writing the tests email while you're mail arrived.
I don't know where 0x10000 came from, but the tests claim that this test should be there.
On 4/24/07, Yuval Fledel yuvalfl@gmail.com wrote:
On 24/04/07, James Hawkins truiken@gmail.com wrote:
On 4/24/07, James Hawkins truiken@gmail.com wrote:
On 4/24/07, Yuval Fledel yuvalfl@gmail.com wrote:
- if (LsaVersion != 0x10000)
What is 0x10000? If it's not defined in the SDK, then please use a #define to clarify what it means.
Also, it would be nice to have some tests for these functions.
Wow, you're fast. I was writing the tests email while you're mail arrived.
I don't know where 0x10000 came from, but the tests claim that this test should be there.
Can you resend the patch with the value #defined?
On 24/04/07, James Hawkins wrote:
Can you resend the patch with the value #defined?
Sure, the last thing I wish to do is ignore review. It should be in your mailbox now.
You actually implicitly found a bug in my tests, which also wrongly made me drop an older version of the implementation just to follow the wrong test.
James Hawkins
-
James Hawkins -
Yuval Fledel