Re: libwine: Add public symbol to access list of debug options.

[Sebastian Lackner]

On 09.10.2016 18:56, Sebastian Lackner wrote:
> Signed-off-by: Sebastian Lackner
>
> Fixes https://bugs.winehq.org/show_bug.cgi?id=41457.
>
> Currently, the "edit debug channels" feature of taskmgr is broken in
> release builds, because:
> - "debug_options" is not exported as a public symbol
> - taskmgr passes SYMOPT_PUBLICS_ONLY to SymSetOptions
>
> This combination does not make any sense (not even installing debug
> packages is sufficient). This patch replaces debug_options with
> __wine_dbg_options and makes it a public symbol.
>
> libs/wine/debug.c          |   24 ++++++++++++------------
>  libs/wine/wine.def         |    1 +
>  libs/wine/wine.map         |    1 +
>  programs/taskmgr/dbgchnl.c |    2 +-
>  programs/winedbg/info.c    |    2 +-
>  5 files changed, 16 insertions(+), 14 deletions(-)

Any opinions regarding this patch? An alternative approach would be
to fix taskmgr (remove SYMOPT_PUBLICS_ONLY), and ask users to install
debug packages if they want to use this feature. Would that be
preferred?

Regards,
Sebastian

libwine: Add public symbol to access list of debug options.

[Alexandre Julliard]

Sebastian Lackner  writes:
> Any opinions regarding this patch? An alternative approach would be
> to fix taskmgr (remove SYMOPT_PUBLICS_ONLY), and ask users to install
> debug packages if they want to use this feature. Would that be
> preferred?

If that works, it's probably good enough. It's better to avoid changing
the libwine public interface if at all possible.