Re: weird ?clipping? errors

[Filip Navara]

Filip Navara wrote:
> James Hawkins wrote:
> > > If the error disappears, then you're dealing with a bug in Wine's
> > > comctl32.dll.
> >
> > I used native comctl32.dll and both of the errors disappeared, so I
> > will take your advice and search around in comctl32.
>
> It's regression in dlls/comctl32/propsheet.c that happend between 
> revision 1.105 and 1.112.

To be more specific, it's this patch:
    Mike McCormack <[e-mail] >
    Adjust the tab contents to fix the propsheet between PSM_KILLACTIVE 
and PSM_SETACTIVE.

Regards,
Fi;lip

weird ?clipping? errors

[James Hawkins]

> To be more specific, it's this patch:
>     Mike McCormack <[e-mail] >
>     Adjust the tab contents to fix the propsheet between PSM_KILLACTIVE
> and PSM_SETACTIVE.

You are correct.  What I would like to do is talk to Mike and see what
the purpose of the patch is (im sure it does something worthwhile) and
then try to fix it so that the clipping problem goes away.

On Sun, 05 Sep 2004 10:20:22 +0200, Filip Navara  wrote:
> Filip Navara wrote:
> > James Hawkins wrote:
> > > > If the error disappears, then you're dealing with a bug in Wine's
> > > > comctl32.dll.
> > >
> > > I used native comctl32.dll and both of the errors disappeared, so I
> > > will take your advice and search around in comctl32.
> >
> > It's regression in dlls/comctl32/propsheet.c that happend between
> > revision 1.105 and 1.112.
>
> To be more specific, it's this patch:
>     Mike McCormack <[e-mail] >
>     Adjust the tab contents to fix the propsheet between PSM_KILLACTIVE
> and PSM_SETACTIVE.
>
> Regards,
> Fi;lip

weird ?clipping? errors

[Mike McCormack]

James Hawkins wrote:
> You are correct.  What I would like to do is talk to Mike and see what
> the purpose of the patch is (im sure it does something worthwhile) and
> then try to fix it so that the clipping problem goes away.

The patch fixes a bug in Macromedia Flash MX 6.  If you open the 
"Publish Settings" dialog from the file menu, it appeared blank.  With 
the patch, it works.  Without the patch it is blank.

After examining the +message trace with the native and the builtin, I 
found that the native comctl32 repositions the contents of the tab 
control immediately after sending a PSM_KILLACTIVE.

I am wondering whether the code to do that should go in 
PROPSHEET_SetCurSel rather than PROPSHEET_CanSetCurSel...

Mike

weird ?clipping? errors

[James Hawkins]

> I am wondering whether the code to do that should go in
> PROPSHEET_SetCurSel rather than PROPSHEET_CanSetCurSel...

I guess it would make more sense because CanSetCurSel seems like it
should only check it it's possible to set current selection, and if it
is possible, then SetCurSel will make the change, but I'm not familiar
with propsheet enough to make that call.

On Sun, 05 Sep 2004 19:16:24 +0900, Mike McCormack  wrote:
> James Hawkins wrote:
> > You are correct.  What I would like to do is talk to Mike and see what
> > the purpose of the patch is (im sure it does something worthwhile) and
> > then try to fix it so that the clipping problem goes away.
>
> The patch fixes a bug in Macromedia Flash MX 6.  If you open the
> "Publish Settings" dialog from the file menu, it appeared blank.  With
> the patch, it works.  Without the patch it is blank.
>
> After examining the +message trace with the native and the builtin, I
> found that the native comctl32 repositions the contents of the tab
> control immediately after sending a PSM_KILLACTIVE.
>
> I am wondering whether the code to do that should go in
> PROPSHEET_SetCurSel rather than PROPSHEET_CanSetCurSel...
>
> Mike