Re: [PATCH] wineboot: detect correct processor name and vendorID, use Intel Pentium 4 as fallback

[Eric Pouech]

Le 20/10/2012 12:42, Patrick Rudolph a écrit :
> This patch need lots of testing, since I can only test it on linux 
> using an Intel CPU.
> Please tests on other OS and systems, too.

please use the ntdll or kernel32 relevant API so that you don't have to 
copy the same code
A+

[PATCH] wineboot: detect correct processor name and vendorID, use Intel Pentium 4 as fallback

[Patrick Rudolph]

Am 2012-10-20 14:54, schrieb Eric Pouech:
> Le 20/10/2012 12:42, Patrick Rudolph a écrit :
> > This patch need lots of testing, since I can only test it on linux 
> > using an Intel CPU.
> > Please tests on other OS and systems, too. please use the ntdll or 
> > kernel32 relevant API so that you don't have to copy the same code
>
> A+

The code was copied from ntdll and modified in order to retrieve 
processorname and vendorID. There's no similiár functionality in wine.

[PATCH] wineboot: detect correct processor name and vendorID, use Intel Pentium 4 as fallback

[Hans Leidekker]

On Sat, 2012-10-20 at 16:04 +0200, Patrick Rudolph wrote:
> Am 2012-10-20 14:54, schrieb Eric Pouech:
> > Le 20/10/2012 12:42, Patrick Rudolph a écrit :
> > > This patch need lots of testing, since I can only test it on linux 
> > > using an Intel CPU.
> > > Please tests on other OS and systems, too. please use the ntdll or 
> > > kernel32 relevant API so that you don't have to copy the same code
> >
> > A+
>
> The code was copied from ntdll and modified in order to retrieve 
> processorname and vendorID. There's no similiár functionality in wine.

There is such functionality in WBEM (formerly known as WMI). I think
you're looking for Win32_Processor.Name and Win32_Processor.Manufacturer.

[PATCH] wineboot: detect correct processor name and vendorID, use Intel Pentium 4 as fallback

[Patrick Rudolph]

Am 2012-10-20 16:52, schrieb Hans Leidekker:
> On Sat, 2012-10-20 at 16:04 +0200, Patrick Rudolph wrote:
> > Am 2012-10-20 14:54, schrieb Eric Pouech:
> > > Le 20/10/2012 12:42, Patrick Rudolph a écrit :
> > > > This patch need lots of testing, since I can only test it on
> >
> > linux
> > > > using an Intel CPU.
> > > > Please tests on other OS and systems, too. please use the ntdll
> >
> > or
> > > > kernel32 relevant API so that you don't have to copy the same
> >
> > code
> > > A+
> >
> > The code was copied from ntdll and modified in order to retrieve
> > processorname and vendorID. There's no similiár functionality in 
> > wine.
>
> There is such functionality in WBEM (formerly known as WMI). I think
> you're looking for Win32_Processor.Name and 
> Win32_Processor.Manufacturer.

It looks like wbem  Win32_Processor.Name / Win32_Processor.Manufacturer 
are only available on i386 compatible systems. What about arm ? Is it 
possible to access both values from wineboot ? I'm not very familar with 
WBEM. Another possible solution would be to try harder to get the 
correct value in wineboot (maybe using the code from wbem) and let wbem 
read the value from the registry. This way there would be no code 
duplication.

[PATCH] wineboot: detect correct processor name and vendorID, use Intel Pentium 4 as fallback

[Hans Leidekker]

On Sat, 2012-10-20 at 18:18 +0200, Patrick Rudolph wrote:
> > > The code was copied from ntdll and modified in order to retrieve
> > > processorname and vendorID. There's no similiár functionality in 
> > > wine.
> >
> > There is such functionality in WBEM (formerly known as WMI). I think
> > you're looking for Win32_Processor.Name and 
> > Win32_Processor.Manufacturer.
>
> It looks like wbem  Win32_Processor.Name / Win32_Processor.Manufacturer 
> are only available on i386 compatible systems. What about arm ? Is it

Support for ARM can be added, but I wouldn't worry about that until we
find an app that needs it.