Re: [OLE #62] Rework the RPC dispatch layer

[Alexandre Julliard]

Mike Hearn  writes:
> ChangeLog:
> - Rework RPC dispatch layer to be simpler and not get confused by
> server/client duality
> - Make threads shut down at the right time and not access freed
> memory after apartment destruction
> - Rename stub_dispatch_thread to client_dispatch_thread
> - Add some more tracing

This badly breaks the regression tests, apparently triggering a bug in
the named pipe handling on the server side. I'm afraid I can't apply
the patch until this is fixed.

[OLE #62] Rework the RPC dispatch layer

[Mike Hearn]

On Wed, 2005-02-02 at 19:34 +0100, Alexandre Julliard wrote:
> This badly breaks the regression tests, apparently triggering a bug in
> the named pipe handling on the server side. I'm afraid I can't apply
> the patch until this is fixed.

Hmm, interesting. I wonder if that's a patch that went in after my last
resync. They worked for me before I submitted the patch. What kind of
breakage are you seeing?

I will resync with CVS and try again.

thanks -mike

[OLE #62] Rework the RPC dispatch layer

[Alexandre Julliard]

Mike Hearn  writes:
> Hmm, interesting. I wonder if that's a patch that went in after my last
> resync. They worked for me before I submitted the patch. What kind of
> breakage are you seeing?

Well the test hangs and the server either stops responding or
crashes. This should never happen so it's clearly a bug on the server
side.

[OLE #62] Rework the RPC dispatch layer

[Mike McCormack]

Alexandre Julliard wrote:
> This badly breaks the regression tests, apparently triggering a bug in
> the named pipe handling on the server side. I'm afraid I can't apply
> the patch until this is fixed.

You mean the one where the server does ConnectPipe, then the client 
does, Open, Close, Open....  I've seen that one before, and will have a 
look at into it if Rob doesn't beat me to it.

I'd also like to make the pipes work properly in overlapped mode, and 
fix overlapped I/O on files ... but Aric wants me to do some MSI stuff 
first.  It will be a busy week :)

Mike

[OLE #62] Rework the RPC dispatch layer

[Mike Hearn]

On Thu, 2005-02-03 at 06:37 +0000, Mike McCormack wrote:
> I'd also like to make the pipes work properly in overlapped mode

I asked Rob to work on this (you're not the only one with a busy week!)
as we'll need it to fix InstallShield.

Specifically we need to be able to read from a name pipe and run a
message loop at the same time.

thanks -mike