2015-03-16 14:48 GMT+01:00 Stefan Dösinger stefan@codeweavers.com:
dlls/ddraw/surface.c | 16 ++++++++ dlls/ddraw/tests/ddraw7.c | 98 +++++++++++++++++++++++++++++++++++++++-------- 2 files changed, 98 insertions(+), 16 deletions(-)
This patch also changes the implementation while the title suggests only additions to the tests. This might come as a surprise a few months down the line in the (admittedly unlikely) case this causes regressions or something similar, so I'd either change the name of the patch or split the implementation change from the test part. Again, it's not that important in this specific case so I don't care much.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-03-16 um 17:43 schrieb Matteo Bruni:
This patch also changes the implementation while the title suggests only additions to the tests. This might come as a surprise a few months down the line in the (admittedly unlikely) case this causes regressions or something similar, so I'd either change the name of the patch or split the implementation change from the test part. Again, it's not that important in this specific case so I don't care much.
I guess you're right, I'll send a patch with an updated title.
-
Matteo Bruni -
Stefan Dösinger