Hi Damjan,
On 11/24/2010 10:10 AM, Damjan Jovanovic wrote:
Changelog:
- atl: add support for binary values in IRegistrar
It appears that 'm' (REG_MULTI_SZ) values do not work on Windows (not even the MSDN example on http://msdn.microsoft.com/en-us/library/ttd53fhh(VS.71).aspx), so this concludes the patch set.
I see some failures on test.winehq.org:
http://test.winehq.org/data/tests/atl:registrar.html
My Win95 also fails and all the Windows boxes that fail, fail with 0x80020009 (DISP_E_EXCEPTION).
Removing both binary values from textA (and the corresponding tests of course) makes the tests succeed on my Win95 box. Does that makes sense?
I could imagine that binary values are not supported on Win95 but the same (?) issue is also present on some NT4, XP and even Windows7. So what decides if binary values are supported?
On 11/27/2010 10:18 PM, Paul Vriens wrote:
I could imagine that binary values are not supported on Win95 but the same (?) issue is also present on some NT4, XP and even Windows7.
The XP and Windows7 failures can be explained by the fact that those users weren't running the tests as Administrator. If I run the tests are a normal user on my WinXP box it also fails with the same errors.
On 11/27/2010 10:50 PM, Paul Vriens wrote:
On 11/27/2010 10:18 PM, Paul Vriens wrote:
I could imagine that binary values are not supported on Win95 but the same (?) issue is also present on some NT4, XP and even Windows7.
The XP and Windows7 failures can be explained by the fact that those users weren't running the tests as Administrator. If I run the tests are a normal user on my WinXP box it also fails with the same errors.
The common denominator here is that both on Win95 and NT4 where the failures occur the version of atl.dll is too old. Both boxes that show failures also show a skip in atl:atl_ax (AtlAxAttachControl is not available).
I'll sent a patch to use a different script on the old versions.
Sorry for using wine-devel as a scratchpad.
Hi Paul,
On 11/27/10 11:11 PM, Paul Vriens wrote:
On 11/27/2010 10:50 PM, Paul Vriens wrote:
On 11/27/2010 10:18 PM, Paul Vriens wrote:
I could imagine that binary values are not supported on Win95 but the same (?) issue is also present on some NT4, XP and even Windows7.
The XP and Windows7 failures can be explained by the fact that those users weren't running the tests as Administrator. If I run the tests are a normal user on my WinXP box it also fails with the same errors.
Sounds easy to fix by using registries inside HKCU instead of HKCR.
The common denominator here is that both on Win95 and NT4 where the failures occur the version of atl.dll is too old. Both boxes that show failures also show a skip in atl:atl_ax (AtlAxAttachControl is not available).
I'll sent a patch to use a different script on the old versions.
Can we please just skip all tests on those versions instead of trying to cope with them? It's not only easier to do but also it will save us efforts in the future when we'll be adding more tests.
Thanks, Jacek
-
Jacek Caban -
Paul Vriens