On 16 March 2014 20:39, Stefan Dösinger stefan@codeweavers.com wrote:
diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 7bb37d6..df725e2 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -1221,6 +1221,7 @@ enum wined3d_display_rotation #define WINED3D_NO3D 0x00000002 #define WINED3D_VIDMEM_ACCOUNTING 0x00000004 #define WINED3D_PRESENT_CONVERSION 0x00000008 +#define WINED3D_ALLOW_3D_DISABLE 0x00000010
Do we really need this? It's perhaps unfortunate that setting "DirectDrawRenderer" to "gdi" would also prevent 3D in d3d8+, but I'm not sure if avoiding that is really worth an extra flag.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-03-17 10:41, schrieb Henri Verbeet:
Do we really need this? It's perhaps unfortunate that setting "DirectDrawRenderer" to "gdi" would also prevent 3D in d3d8+, but I'm not sure if avoiding that is really worth an extra flag.
Maybe not. Although we could think this one step further and consider removing the key and instead implement this functionality with an opengl32.dll = disabled override.
Please ignore this patch for now. I'll investigate how well the opengl32 override works for this purpose.
There's the theoretical possibility that an application uses d3d8 for main rendering and ddraw for GPU detection that fails for some reason without DirectDrawRenderer=gdi, but that would be a bug that needs a fix elsewhere.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-03-17 11:34, schrieb Stefan Dösinger:
Although we could think this one step further and consider removing the key and instead implement this functionality with an opengl32.dll = disabled override.
Actually, this might not be a good idea. There's still the use case of using our ddraw on Windows with 2D only support where dll overrides are not available.
-
Henri Verbeet -
Stefan Dösinger