Pavel Roskin wrote:
Hello!
HeapReAlloc() would crash on Windows 2000 is the original pointer is NULL. This causes the Andreas Mohr's uninstaller to crash.
there's lot of code which relies on HeapReAlloc would allocate a block if the block to reallocate is NULL (as realloc does in stdlib). this is not the case in windows, and we should fix it (and first, fix all the wine code relying on this) Dimi, may be something to add to the Janitorial list...
Maybe, we could also keep a least of the most common traps in win32 API for unix programmers...
A+
Why not fix HeapReAlloc first and see which apps crash? ;-) Anyway, fixing this seems to be a task I could do, so, if someone could give me instructions on how to do it ...
Philipp
On Wednesday 24 September 2003 21:24, Eric Pouech wrote:
Pavel Roskin wrote:
Hello!
HeapReAlloc() would crash on Windows 2000 is the original pointer is NULL. This causes the Andreas Mohr's uninstaller to crash.
there's lot of code which relies on HeapReAlloc would allocate a block if the block to reallocate is NULL (as realloc does in stdlib). this is not the case in windows, and we should fix it (and first, fix all the wine code relying on this) Dimi, may be something to add to the Janitorial list...
Maybe, we could also keep a least of the most common traps in win32 API for unix programmers...
A+
Philipp Wollermann wrote:
Why not fix HeapReAlloc first and see which apps crash? ;-)
it's not a matter of knowing which apps break, but which APIs would break...
Anyway, fixing this seems to be a task I could do, so, if someone could give me instructions on how to do it ...
cd wine find . -name '*.[chyl]' -print | xargs grep HeapReAlloc and then check that we don't, from the code, reallocate a NULL buffer for example, just browsing the begining of the list in dlls/user/message.c, the code handling dde_pairs is wrong
A+
-
Eric Pouech -
Philipp Wollermann