Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

[Stefan Dösinger]

Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička:
> DirectX 1 interface allowed creation of explicit back buffers, so move the
> restrictive checks to DirectX 2+ implementations.

It is still missing testing/handling of AddAttachedSurface

[PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

[Roderick Colenbrander]

On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger
 wrote:
> Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička:
> > DirectX 1 interface allowed creation of explicit back buffers, so move the
> > restrictive checks to DirectX 2+ implementations.
>
> It is still missing testing/handling of AddAttachedSurface

Oldřich, while you are at it also check what happens if
DDSCAPS_3DDEVICE is used on a standalone backbuffer surface.

Roderick

[PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

[Oldřich Jedlička]

Hi Roderick,

On Thursday 22 July 2010 22:26:39 Roderick Colenbrander wrote:
> On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger
>
>  wrote:
> > Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička:
> > > DirectX 1 interface allowed creation of explicit back buffers, so move
> > > the restrictive checks to DirectX 2+ implementations.
> >
> > It is still missing testing/handling of AddAttachedSurface
>
> Oldřich, while you are at it also check what happens if
> DDSCAPS_3DDEVICE is used on a standalone backbuffer surface.

Ok, I will add test with DDSCAPS_BACKBUFFER | DDSCAPE_3DDEVICE. Let's see if 
this is supported.

Oldrich.
> Roderick

[PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

[Oldřich Jedlička]

Hi Roderick,

On Thursday 22 July 2010 22:26:39 Roderick Colenbrander
wrote:
> On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger

 wrote:
> > Am 22.07.2010 um 21:13 schrieb Oldřich

Jedlička:
> > > DirectX 1 interface allowed creation of explicit back

buffers, so move
> > > the restrictive checks to DirectX 2+

implementations.
> > It is still missing testing/handling of

AddAttachedSurface
> Oldřich, while you are at it also check what happens

if
> DDSCAPS_3DDEVICE is used on a standalone backbuffer surface.

I'm
currently facing problems of missing test machine (no Windows XP), but I
will try to get some :-) I want to add some 3DDEVICE creation tests to my
test suite.

Anyway, we have a real test case for BACKBUFFER + 3DDEVICE,
which is a game Warhammer: Dark Omen (bug #9190). It creates a 3D backbuffer
too, but fails later while playing with other surfaces - it tries to get
some ZBUFFER surface via GetAttachedSurface(), but that doesn't find
anything.

Oldřich.
> Roderick