Re: crtdll: Declare some variables static

[Marcus Meissner]

On Wed, Jan 03, 2007 at 03:45:28PM +0000, Andrew Talbot wrote:
> Changelog:
>     crtdll: Declare some variables static.

Err, why?

They are clearly exported from the .spec file and you just killed the exports?

They likely are used by Windows programs.

Ciao, Marcus

crtdll: Declare some variables static

[Andrew Talbot]

Marcus Meissner wrote:
> Err, why?
>
> They are clearly exported from the .spec file and you just killed the
> exports?
>
> They likely are used by Windows programs.
>
> Ciao, Marcus

Hi Marcus,

I trusted the comment just before the declarations, which says:

/* The following data items are not exported from msvcrt */.

-- Andy.

crtdll: Declare some variables static

[Robert Shearman]

Andrew Talbot wrote:
> Marcus Meissner wrote:
> > Err, why?
> >
> > They are clearly exported from the .spec file and you just killed the
> > exports?
> >
> > They likely are used by Windows programs.
> >
> > Ciao, Marcus
>
> Hi Marcus,
>
> I trusted the comment just before the declarations, which says:
>
> /* The following data items are not exported from msvcrt */.

However, it had an implicit "... but they are exported from this DLL."

crtdll: Declare some variables static

[Andrew Talbot]

Robert Shearman wrote:
> However, it had an implicit "... but they are exported from this DLL."

Right. My brain has just caught up with you.

As you can see, I'm trawling through the dlls looking for anything I can
legitimately take out of the global namespace. I am trying to be as careful
as I can, and am unlikely to make the same mistake twice. But I ask people
to be patient with me if I stumble a bit.

I thought this patch might be questionable, but it just seemed easier to
publish it and have it rejected than to discuss it on wine-devel in
advance.

I'm definitely going to be more wary of functions that appear in spec files,
from now on.

Thanks to you and Marcus for your help.

-- Andy.