Re: [1/3] server: Add field for window display affinity.

[Alexandre Julliard]

Andrew Wesie  writes:
> Signed-off-by: Andrew Wesie
>
> include/wine/server_protocol.h | 9 ++++++---
>  server/protocol.def            | 3 +++
>  server/request.h               | 4 +++-
>  server/window.c                | 4 ++++
>  4 files changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h
> index d31579c..f442a94 100644
> --- a/include/wine/server_protocol.h
> +++ b/include/wine/server_protocol.h
> @@ -47,7 +47,7 @@ struct reply_header
>
> struct request_max_size
>  {
> - int pad[16];
> - int pad[18];
>
> };

You can't change the request size. Also note that this is a generated
file, updated by tools/make_requests.

Do you have an app that uses this across processes? Otherwise you can
probably simply store a local flag for now.

[1/3] server: Add field for window display affinity.

[Andrew Wesie]

Thanks. I wasn't completely sure how the server stuff was generated.

I'm happy to use a local flag instead. The app only needs a stub, honestly,
so if that is preferred I can submit that instead.

-Andrew

On Mon, Jun 26, 2017 at 2:14 AM, Alexandre Julliard 
wrote:
> Andrew Wesie  writes:
> > Signed-off-by: Andrew Wesie
> >
> > include/wine/server_protocol.h | 9 ++++++---
> >  server/protocol.def            | 3 +++
> >  server/request.h               | 4 +++-
> >  server/window.c                | 4 ++++
> >  4 files changed, 16 insertions(+), 4 deletions(-)
> >
> > diff --git a/include/wine/server_protocol.h b/include/wine/server_
>
> protocol.h
> > index d31579c..f442a94 100644
> > --- a/include/wine/server_protocol.h
> > +++ b/include/wine/server_protocol.h
> > @@ -47,7 +47,7 @@ struct reply_header
> >
> > struct request_max_size
> >  {
> > - int pad[16];
> > - int pad[18];
> >
> > };
>
> You can't change the request size. Also note that this is a generated
> file, updated by tools/make_requests.
>
> Do you have an app that uses this across processes? Otherwise you can
> probably simply store a local flag for now.
>
> --
> Alexandre Julliard
> [e-mail]

[1/3] server: Add field for window display affinity.

[Alexandre Julliard]

Andrew Wesie  writes:
> Thanks. I wasn't completely sure how the server stuff was generated.
>
> I'm happy to use a local flag instead. The app only needs a stub, honestly, so if that is preferred I can submit that instead.

If that's enough for the app, a stub would be fine. We can worry about
making it more correct once we find something that uses it.