Re: [PATCH 0/5] Moving bare consoles to wineconsole (try #2)

[Alexandre Julliard]

Eric Pouech  writes:
> The following series implements a new scheme for managing 'bare' consoles.
> We now force every program started without a wine parent to be run under
> wineconsole (transparently for the user).
> This is done using a new backend in wineconsole called 'line'. This backend
> only takes care of input; output is kept as a client side operation.
> All terminal related code is moved from dlls/kernel32 to programs/wineconsole.
>
> This basically ensures that:
> - Only wineconsole reads from standard input (and writes into input queue).
> This fixes bug reported by Jason when $CONIN is opened with read access only.
> - It also enforces that wineconsole always has control of the unix terminal,
> hence ensuring that we properly reset the terminal settings upon exit.
>
> Code looks way cleaner now.
>
> Try #2 (changes from previous patch)
> - fix changelog of first patch (was WineHelp...)
> - fix date in header for new file
> - remove setting title code (will be fixed in later patch)

Actually the problem is not only the title. For instance it's still
sending escape sequences when stdout is redirected.

[PATCH 0/5] Moving bare consoles to wineconsole (try #2)

[Eric Pouech]

> Try #2 (changes from previous patch)
> > - fix changelog of first patch (was WineHelp...)
> > - fix date in header for new file
> > - remove setting title code (will be fixed in later patch)
>
> Actually the problem is not only the title. For instance it's still
> sending escape sequences when stdout is redirected.
>
> did you test that for the last patch in the patchset or for items in the

middle of the patchset ?
it's intended to work only for the last one in the patchset as it's easier
to do it when the old code is removed, and not changing the old code to
make it work in patch#2 and erase it in next patch
A+

[PATCH 0/5] Moving bare consoles to wineconsole (try #2)

[Alexandre Julliard]

Eric Pouech  writes:
> > Try #2 (changes from previous patch)
> > - fix changelog of first patch (was WineHelp...)
> > - fix date in header for new file
> > - remove setting title code (will be fixed in later patch)
>
>
> Actually the problem is not only the title. For instance it's
> still
> sending escape sequences when stdout is redirected.
>
>
> did you test that for the last patch in the patchset or for items in
> the middle of the patchset ?

Yes, it happens with all the patches applied.

[PATCH 0/5] Moving bare consoles to wineconsole (try #2)

[Eric Pouech]

hmm, that was intended to work (and did work for try#1, even though I
didn't retest it in #2) :-(
I'll look at it
A+

2012/12/19 Alexandre Julliard
> Eric Pouech  writes:
> > > Try #2 (changes from previous patch)
> > > - fix changelog of first patch (wastWineHelp...)
> > > - fix date in header for new file
> > > - remove setting title code (will be fixed in later patch)
> >
> >
> > Actually the problem is not only the title. For instance it's
> > still
> > sending escape sequences when stdout is redirected.
> >
> >
> > did you test that for the last patch in the patchset or for items in
> > the middle of the patchset ?
>
> Yes, it happens with all the patches applied.
>
> --
> Alexandre Julliard
> [e-mail]