Hi Guys:
I really appreciate all the responses to my work on this bug http://bugs.winehq.org/show_bug.cgi?id=22918
Especially the fact that you guys are looking at this code is very very important to me, as it will have to be eventually reviewed to be submitted to Wine.
However, I am a little frustrated as the comments I received were things already discussed on wine-devel.
I find myself in quite the lucky position that I can work on Wine for some time. I do this with no economic compensation of any kind (as I guess most of you as well - except Codeweavers people grin ;) - oh and full disclosure with the exception of a book on DirectX and hopefully a trip to WineConf ;) ).
However, I'd like to spend the time actually coding, not referencing wine-devel.
In any case, I'd appreciate it if you have a comment on my code/patches, esp if it might have already been discussed on wine-devel, please don't "shoot from the hip" and check wine-devel first...
Anyway enough venting.
Off to work. Again I appreciate the attention to my patches.
Misha
Misha Koshelev wrote:
Hi Guys:
I really appreciate all the responses to my work on this bug http://bugs.winehq.org/show_bug.cgi?id=22918
Misha:
Not everyone gets or reads the wine-devel mailing list. It is good to duplicate what appears in the mailing list into the bug report that it affects. Don't expect folks to change.
However, if someone is being rude or obnoxious, please feel free to let them know.
Everyone else:
I'll be the first to bite on this: Please be friendly. I know that I've been a little uptight the last few days, but it all over how we code and what we code. Remember, folks are not going to figure out what you were doing when trying to fix a bug six months from now that was inadvertantly caused by bad coding practices. Look over your code before submitting it. Look for tabs instead of spaces, dangling or unnecessary white space, use of 'obtuse' variables (i, j, k for counters in for/do/while loops is accepted practice, count is obvious, count_for_this_loop is unnecessary), constants on the right side of if statements (why you ask? Try using =, | or & instead of ==, || or && once and see the fireworks, switch it around and you get a compiler error "cannot change constant"). Other things like using MSDN variables when we could/should use WINE....
Something that I've noticed is that some code is unnecessarily complex. Simple solutions work best and are easy to maintain. Remember, you might not be the next to touch your code.
Thank you for reading and please folks, if you want to hammer me, do it off the list. We don't need this to degrade into a flame war.
James McKenzie Coding in 'c' since 1981 Former member, WINOS/2 Former member, Project Odinn.
James McKenzie jjmckenzie51@earthlink.net writes:
I'll be the first to bite on this: Please be friendly. I know that I've been a little uptight the last few days, but it all over how we code and what we code. Remember, folks are not going to figure out what you were doing when trying to fix a bug six months from now that was inadvertantly caused by bad coding practices. Look over your code before submitting it. Look for tabs instead of spaces, dangling or unnecessary white space, use of 'obtuse' variables (i, j, k for counters in for/do/while loops is accepted practice, count is obvious, count_for_this_loop is unnecessary), constants on the right side of if statements (why you ask? Try using =, | or & instead of ==, || or && once and see the fireworks, switch it around and you get a compiler error "cannot change constant").
Writing if statements the wrong way around is silly and makes the code harder to read. Don't do that. (And no, I don't care what your programming book says on the subject).
-
Alexandre Julliard -
James McKenzie -
Misha Koshelev