Re: Resend: Try 3: user32.dll fix and test ShowOwnedPopups

[Vitaliy Margolen]

Any reason why the whole patch wasn't committed?

Vitaliy Margolen

Sunday, June 5, 2005, 5:43:14, Vitaliy Margolen wrote:
> It looks like DefWinProc needs to be smarter about WM_SHOWWINDOW when lParam!=0.
> Added more tests for WM_SHOWWINDOW to test that it could be used as
> ShowOwnedPopup (for single window).
> This time with input from Dmitry. Moved tests to msg.c
> ShowOwnedPopups should handle none WS_POPUP style windows as well. DefWinProc
> should do the same for WM_SHOWWINDOW.
> Match names for WM_SHOWWINDOW status codes to MSDN
> ShowWindow(hwnd, SW_HIDE) should change Z-order thus omit SWP_NOZORDER from call
> to SetWindowPos, but only for none active windows also adding SWP_NOACTIVATE
> Vitaliy Margolen
> changelog:
>   include/winuser.h
>     Match names for WM_SHOWWINDOW status codes to MSDN
>   dlls/user/win.c
>     ShowOwnedPopups should handle none WS_POPUP style windows as well.
>   dlls/user/defwnd.c
>     WM_SHOWWINDOW should show/hide none WS_POPUP style windows as well.
>   dlls/user/tests/msg.c
>     Tests for ShowOwnedPopups
>   dlls/x11drv/winpos.c
>     Fix flags in ShowWindow(,SW_HIDE) for active/none active windows

Resend: Try 3: user32.dll fix and test ShowOwnedPopups

[Alexandre Julliard]

Vitaliy Margolen  writes:
> Any reason why the whole patch wasn't committed?

I suspect the x11drv change needs to be done in SetWindowPos (and it
should have been a separate patch anyway...)