RE: d3d9: Use the correct size for D3DFVF_XYZW [try 2]

[Stefan Dösinger]

we have a similar, but not quite the same, routine in wined3d too, I think
in device.c. It creates a wined3d vertex declaration from a FVF, while the
d3d9 one creates a d3d9 declaration. Can you see if the wined3d routine is
affected too?

I didn't unify the wined3d and d3d9 code because we'd need need some
wined3d->d3d9 decl backwards conversion which is probably as bug prone and
maintainance heavy as an almost-clone of the FVF->decl conversion routine,
and I dislike the idea of creating a d3d9 decl in wined3d. If anyone has a
nice solution for this feel free to suggest it.
> -----Original Message-----
> From: [e-mail] [mailto:wine-patches-
> [e-mail]] On Behalf Of Chris Robinson
> Sent: Sunday, December 28, 2008 6:59 PM
> To: [e-mail]
> Subject: d3d9: Use the correct size for D3DFVF_XYZW [try 2]
>
> Now with a test.

d3d9: Use the correct size for D3DFVF_XYZW [try 2]

[Henri Verbeet]

2008/12/30 Stefan Dösinger :
> we have a similar, but not quite the same, routine in wined3d too, I think
> in device.c. It creates a wined3d vertex declaration from a FVF, while the
> d3d9 one creates a d3d9 declaration. Can you see if the wined3d routine is
> affected too?

That's commit f197e8b1ca0662c32444741112b27cc98038e2ba.
> I didn't unify the wined3d and d3d9 code because we'd need need some
> wined3d->d3d9 decl backwards conversion which is probably as bug prone and
> maintainance heavy as an almost-clone of the FVF->decl conversion routine,
> and I dislike the idea of creating a d3d9 decl in wined3d. If anyone has a
> nice solution for this feel free to suggest it.

ConvertFvfToDeclaration() returns an array of WINED3DVERTEXELEMENT.
Converting from WINED3DVERTEXELEMENT to D3DVERTEXELEMENT is trivial.