[PATCH] ntdll/tests: Fix failures in the file tests [v2]

[Detlef Riekenberg]

v2:
Removed the test for GetLastError() on success

Example test failure:
http://test.winehq.org/data/c6ff0e01224e86c7baa31d019fcb0a7bf03e2f96/win10_d...

Patch tested:
https://testbot.winehq.org/JobDetails.pl?Key=50393

--
bye bye ...
        ... Detlef

Signed-off-by: Detlef Riekenberg 
---
 dlls/ntdll/tests/file.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c
index d107c2ed2b..ce1619e4e1 100644
--- a/dlls/ntdll/tests/file.c
+++ b/dlls/ntdll/tests/file.c
@@ -4463,8 +4463,7 @@ static void test_read_write(void)
         bytes = 0xdeadbeef;
         SetLastError(0xdeadbeef);
         ret = GetOverlappedResult(hfile, &ovl, &bytes, TRUE);
-        ok(ret, "GetOverlappedResult should report TRUE\n");
-        ok(GetLastError() == 0xdeadbeef, "expected 0xdeadbeef, got %d\n", GetLastError());
+        ok(ret, "GetOverlappedResult returned FALSE with %u (expected TRUE)\n", GetLastError());
         ok(bytes == 0, "expected 0, read %u\n", bytes);
         ok((NTSTATUS)ovl.Internal == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#lx\n", ovl.Internal);
         ok(ovl.InternalHigh == 0, "expected 0, got %lu\n", ovl.InternalHigh);
@@ -4492,8 +4491,7 @@ static void test_read_write(void)
         bytes = 0xdeadbeef;
         SetLastError(0xdeadbeef);
         ret = GetOverlappedResult(hfile, &ovl, &bytes, TRUE);
-        ok(ret, "GetOverlappedResult should report TRUE\n");
-        ok(GetLastError() == 0xdeadbeef, "expected 0xdeadbeef, got %d\n", GetLastError());
+        ok(ret, "GetOverlappedResult returned FALSE with %u (expected TRUE)\n", GetLastError());
         ok(bytes == 0, "expected 0, read %u\n", bytes);
         ok((NTSTATUS)ovl.Internal == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#lx\n", ovl.Internal);
         ok(ovl.InternalHigh == 0, "expected 0, got %lu\n", ovl.InternalHigh);
--
2.21.0.windows.1

[PATCH] tools: Increase the failure limit to get more win10 test runs displayed on the winetest result pages [v2]

[Detlef Riekenberg]

The old puffer was not big enough.
winetest results for win10 v1803 should now reach the result page

Mar 31 00:25:01 	cw1-hd6800-1803-t64: too many failed test units (>70 at user32:win)
Mar 30 23:50:02 	cw1-hd6800-1803-t32: too many failed test units (>70 at wininet:internet)
Mar 30 15:35:02 	cw2-gtx560-1803-t64: too many failed test units (>70 at vbscript:createobj)
Mar 30 15:05:02 	cw2-gtx560-1803-t32: too many failed test units (>70 at wininet:internet)

(My win10 machine had 90 failures on 12.March and reached the old limit at urlmon:url)

There will be still test machines rejected:
*cw2-gtx560-wow64 reaches 50 failures at dinput:mouse
 this is too far away from a usable limit
*winetest reports other machines reach the file size limit
 (newtb-debian9-wow64, fg-deb64-wow32, fg-deb64-wow64,fg-deb64-t32, fgtb-debian9-wow64)
 Some of them reach the current filesize limit near the end (urlmon or user32).
 Relaxing the limit by 500k might be enough, to get these test results displayed,
 but that is only useful, when someone works on fixing the failures.

v2:
Added missing Signed off

--
bye bye ...
        ... Detlef

Signed-off-by: Detlef Riekenberg 
---
 winetest/dissect | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winetest/dissect b/winetest/dissect
index a468812..86a5dc2 100755
--- a/winetest/dissect
+++ b/winetest/dissect
@@ -369,7 +369,7 @@ foreach my $entry (@idmatch)
     }
 }
 # Give a little slack to the Windows 10 1709.
-$maxfailedtests += 20 if ($version eq "win10");
+$maxfailedtests += 45 if ($version eq "win10");

if ($prediluvian and not $acceptprediluvianwin)
 {
--
2.21.0.windows.1