Hello,
I am trying to run the wine tests with `make test` but a lot of tests seem to fail which is getting in my way of testing some failed tests are reported by 'testbot'. For instance, currently, running `make test` fails with:
security.c:4736: Tests skipped: Couldn't create an object for GetSecurityInfo test 0024:fixme:advapi:SetEntriesInAclW unhandled access mode 4 0024:fixme:advapi:SetEntriesInAclW unhandled access mode 4 security.c:7735: Test failed: got error 2 security.c:7738: Test failed: got error 6 security.c:7743: Test failed: got error 6 security.c:7746: Test failed: wait failed security.c:7843: Test failed: got error 2 security.c:7844: Test failed: wait failed security.c:7847: Test succeeded inside todo block: expected failure security.c:7854: Test failed: got error 2 security.c:7862: Test failed: got error 2 security.c:7869: Test failed: got error 2 security.c:7879: Test failed: got error 2 security.c:7889: Test failed: got error 2 security.c:7890: Test failed: wait failed 0024:fixme:ntdll:NtSetInformationToken unimplemented class 18 0024:fixme:ntdll:NtSetInformationToken unimplemented class 20 security.c:7248: Test failed: CreateProcess failed with error 2 security.c:7249: Test failed: Could not wait for the child process: -1 le=6 make: *** [Makefile:3396: dlls/advapi32/tests/security.ok] Error 21
Disabling this test in the Makefile leads to more errors in the tests. Is this normal? I am pretty new to Wine and could be missing something.
What could I be missing?
Regards, David
On 10/17/2021 10:46 AM, David Kahurani wrote:
Disabling this test in the Makefile leads to more errors in the tests. Is this normal? I am pretty new to Wine and could be missing something.
I speak as a casual contributor and not as someone who knows the project well, but I think there are lots of failing tests, and ideally there should be no failures as such (no "Test failed" or "Test succeeded inside todo block" messages should be printed).
-Jefferson
On Sun, Oct 17, 2021 at 3:46 PM Jefferson Carpenter < jeffersoncarpenter2@gmail.com> wrote:
On 10/17/2021 10:46 AM, David Kahurani wrote:
Disabling this test in the Makefile leads to more errors in the tests. Is this normal? I am pretty new to Wine and could be missing something.
I speak as a casual contributor and not as someone who knows the project well, but I think there are lots of failing tests, and ideally there should be no failures as such (no "Test failed" or "Test succeeded inside todo block" messages should be printed).
Could it possibly have to do with the distros and different versions of packages shipping with different distros? That was/is my first guess since the test server logs do not seem to have numerous irrelevant fails.
-Jefferson
On 10/17/2021 1:05 PM, David Kahurani wrote:
On Sun, Oct 17, 2021 at 3:46 PM Jefferson Carpenter < jeffersoncarpenter2@gmail.com> wrote:
On 10/17/2021 10:46 AM, David Kahurani wrote:
Disabling this test in the Makefile leads to more errors in the tests. Is this normal? I am pretty new to Wine and could be missing something.
I speak as a casual contributor and not as someone who knows the project well, but I think there are lots of failing tests, and ideally there should be no failures as such (no "Test failed" or "Test succeeded inside todo block" messages should be printed).
Could it possibly have to do with the distros and different versions of packages shipping with different distros? That was/is my first guess since the test server logs do not seem to have numerous irrelevant fails.
I think that the test server logs only report new failures, but getting Wine to work in all distros/package configurations, or correctly marking tests as todo_wine, would be helpful.
On Sun, 17 Oct 2021, David Kahurani wrote: [...]
Disabling this test in the Makefile leads to more errors in the tests. Is this normal? I am pretty new to Wine and could be missing something.
It's not normal: conformance tests should not be failing. It's expected: Wine has had test failures for years.
Currently there's no way you can get 'make test' to succeed. [1] (please, please, take that as a challenge!).
https://test.winehq.org/data/patterns.html https://test.winehq.org/data/ (specifically, the Linux column)
[1] I'll mention this just in case, but step one is making sure not to use parallel make when running the tests.
-
David Kahurani -
Francois Gouget -
Jefferson Carpenter