Wine bot results

[Alistair Leslie-Hughes]

Hi,

I have a patch that when run on on the testbot, it fails on all but two 
machines.
However when I build the exe myself and run it, it pass on all but two 
machines.

http://testbot.winehq.org/JobDetails.pl?Key=21257
http://testbot.winehq.org/JobDetails.pl?Key=21256

Ubuntu 12.04.

Any Ideas on the different results?

Best Regards
 Alistair Leslie-Hughes

[Dmitry Timoshkov]

Alistair Leslie-Hughes  wrote:
> I have a patch that when run on on the testbot, it fails on all but two 
> machines.
> However when I build the exe myself and run it, it pass on all but two 
> machines.
>
> http://testbot.winehq.org/JobDetails.pl?Key=21257
> http://testbot.winehq.org/JobDetails.pl?Key=21256
>
> Ubuntu 12.04.
>
> Any Ideas on the different results?

This probably means that behaviour is undefined and depends on memory
contents.

[Qian Hong]

Hello Alistair,

On Tue, Aug 28, 2012 at 6:04 PM, Alistair Leslie-Hughes
 wrote:
> http://testbot.winehq.org/JobDetails.pl?Key=21257
> http://testbot.winehq.org/JobDetails.pl?Key=21256

I downloaded your patch from
http://testbot.winehq.org/GetFile.pl?JobKey=21257&StepKey=1 ,
compiled with i686-w64-mingw32-gcc on Ubuntu 10.10,
then resubmit it to wine testbot, my result is the same as the one
built by testbot:
https://testbot.winehq.org/JobDetails.pl?Key=21288

Maybe it is interesting to know what compiler you use and which one is
used by testbot.
Though we should make sure we are always test on the same patch first =)

$ i686-w64-mingw32-gcc -v
Using built-in specs.
COLLECT_GCC=i686-w64-mingw32-gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/i686-w64-mingw32/4.6.1/lto-wrapper
Target: i686-w64-mingw32
Configured with: ../../src/configure --build=i686-linux-gnu
--prefix=/usr --includedir='/usr/include' --mandir='/usr/share/man'
--infodir='/usr/share/info' --sysconfdir=/etc --localstatedir=/var
--libexecdir='/usr/lib/gcc-mingw-w64' --disable-maintainer-mode
--disable-dependency-tracking --prefix=/usr --disable-shared
--disable-multilib --enable-linker-build-id --with-system-zlib
--libexecdir=/usr/lib --without-included-gettext --libdir=/usr/lib
--enable-libstdcxx-time=yes --with-tune=generic
--enable-version-specific-runtime-libs
--enable-languages=c,c++,fortran --enable-lto --with-plugin-ld
--enable-fully-dynamic-string --target=i686-w64-mingw32
--with-gxx-include-dir=/usr/include/c++/4.6
--with-as=/usr/bin/i686-w64-mingw32-as
--with-ld=/usr/bin/i686-w64-mingw32-ld
Thread model: win32
gcc version 4.6.1 (GCC)

[Alistair Leslie-Hughes]

Hi Qian,
> $ i686-w64-mingw32-gcc -v
> Using built-in specs.
> COLLECT_GCC=i686-w64-mingw32-gcc
> COLLECT_LTO_WRAPPER=/usr/lib/gcc/i686-w64-mingw32/4.6.1/lto-wrapper
> Target: i686-w64-mingw32
> Configured with: ../../src/configure --build=i686-linux-gnu
> --prefix=/usr --includedir='/usr/include' --mandir='/usr/share/man'
> --infodir='/usr/share/info' --sysconfdir=/etc --localstatedir=/var
> --libexecdir='/usr/lib/gcc-mingw-w64' --disable-maintainer-mode
> --disable-dependency-tracking --prefix=/usr --disable-shared
> --disable-multilib --enable-linker-build-id --with-system-zlib
> --libexecdir=/usr/lib --without-included-gettext --libdir=/usr/lib
> --enable-libstdcxx-time=yes --with-tune=generic
> --enable-version-specific-runtime-libs
> --enable-languages=c,c++,fortran --enable-lto --with-plugin-ld
> --enable-fully-dynamic-string --target=i686-w64-mingw32
> --with-gxx-include-dir=/usr/include/c++/4.6
> --with-as=/usr/bin/i686-w64-mingw32-as
> --with-ld=/usr/bin/i686-w64-mingw32-ld
> Thread model: win32
> gcc version 4.6.1 (GCC)

$ i586-mingw32msvc-gcc -v
Using built-in specs.
Target: i586-mingw32msvc
Configured with: 
/build/buildd/mingw32-4.2.1.dfsg/build_dir/src/gcc-4.2.1-2-dfsg/configure -v 
 --prefix=/usr --target=i586-mingw32msvc --enable-languages=c,c++ --enable-threads 
 --enable-sjlj-exceptions --disable-multilib --enable-version-specific-runtime-libs
Thread model: win32
gcc version 4.2.1-sjlj (mingw32-2)

Here is what install on my system,  Ill try to update it to a later version.

Best Regards
 Alistair Leslie-Hughes

[Saulius Krasuckas]

* On Tue, 28 Aug 2012, Alistair Leslie-Hughes wrote:
> > Target: i686-w64-mingw32

...
> Target: i586-mingw32msvc

There was the same topic brought up two years ago:
http://www.winehq.org/pipermail/wine-devel/2010-September/086643.html

IIRC, MSVC and i586-mingw32msvc compilers initialize every declared 
variable while *-mingw32* one does not.

S.

[Saulius Krasuckas]

* On Tue, 28 Aug 2012, Saulius Krasuckas wrote:
> - On Tue, 28 Aug 2012, Alistair Leslie-Hughes wrote:
> > > Target: i686-w64-mingw32
>
> ...
> > Target: i586-mingw32msvc
>
> There was the same topic brought up two years ago:
> http://www.winehq.org/pipermail/wine-devel/2010-September/086643.html
>
> IIRC, MSVC and i586-mingw32msvc compilers initialize every declared 
> variable while *-mingw32* one does not.

I mean *-mingw32-gcc (the one not using MSVCRT.DLL) with the latter;)

S.

[Jacek Caban]

On 08/28/12 12:04, Alistair Leslie-Hughes wrote:
> Hi,
>
> I have a patch that when run on on the testbot, it fails on all but
> two machines.
> However when I build the exe myself and run it, it pass on all but two
> machines.
>
> http://testbot.winehq.org/JobDetails.pl?Key=21257
> http://testbot.winehq.org/JobDetails.pl?Key=21256
>
> Ubuntu 12.04.
>
> Any Ideas on the different results?

+       VariantClear(&d);
+       V_VT(&v) = VT_BSTR;
+       V_BSTR(&v) = SysAllocStringLen(NULL, 0);

This VariantClear call attempts to free uninitialized VARIANT instance.
You probably meant VariantInit().

Jacek

[Alistair Leslie-Hughes]

Hi Jacek,

--------------------------------------------------
From: "Jacek Caban" 
Sent: Wednesday, August 29, 2012 1:16 AM
To: "Alistair Leslie-Hughes" 
Cc: 
Subject: Re: Wine bot results
> This VariantClear call attempts to free uninitialized VARIANT instance.
> You probably meant VariantInit().

Thanks,  it works on all systems now.

Best Regards
 Alistair Leslie-Hughes