ITypeInfo_fnGetContainingTypeLib

Good day!

Anyone like to take a swat at this?  I don't normally shy from a page
fault, but frankly, ICOM confuses me.  Anyway, maybe Ove can spot it in
a second.  If I have to do it it may take weeks.  Backtrace attached.
Wineconsole seems to be working nicely, as long as the resolution is
good and high.

I wanted to include a typelib trace, but that crashes at an earlier
spot.  I haven't really looked at that one yet; I can send it along if
anyone is interested.  At least Wine is starting to get its teeth into
InstallSh**** and its confounded IKernel.exe.

Regards

Lawson
---oof---

[Huw D M Davies]

On Sat, Nov 24, 2001 at 06:58:47PM -0500, [e-mail] wrote:
> Good day!
>
> Anyone like to take a swat at this?  I don't normally shy from a page
> fault, but frankly, ICOM confuses me.  Anyway, maybe Ove can spot it in
> a second.  If I have to do it it may take weeks.  Backtrace attached.
> Wineconsole seems to be working nicely, as long as the resolution is
> good and high.
>
> I wanted to include a typelib trace, but that crashes at an earlier
> spot.  I haven't really looked at that one yet; I can send it along if
> anyone is interested.  At least Wine is starting to get its teeth into
> InstallSh**** and its confounded IKernel.exe.

I'd 'like' to see the typelib trace, so if you could send me that I'd be
grateful.

Thanks,
Huw.

On Sun, 25 Nov 2001, Huw D M Davies wrote:
> I'd 'like' to see the typelib trace, so if you could send me that I'd be
> grateful.
>
> Thanks,
> Huw.

No worry!  I can alwaus make another one.

Lawson

On Sun, 25 Nov 2001, Huw D M Davies wrote:
> I'd 'like' to see the typelib trace, so if you could send me that I'd be
> grateful.
>
> Thanks,
> Huw.

Maybe not.  I seem to have current cvs + install.diff
(http://www.winehq.com/~ovek/install.diff), and it does crash in
proxy.c...  I hope it is useful, or at least not too pernicious.

Lawson

[Ove Kaaven]

On Sat, 24 Nov 2001 [e-mail] wrote:
> Anyone like to take a swat at this?

I've explained it before on this list - you need to apply a typelib
refcounting patch, and there is one by Malte somewhere in the wine-patches
archives. But since you ask, here is the refcounting pieces of the patch
we use in WineX:

Index: typelib.c
===================================================================
RCS file: /cvsroot/winex/wine/dlls/oleaut32/typelib.c,v
retrieving revision 1.1.1.17
diff -u -r1.1.1.17 typelib.c
--- typelib.c	2001/10/28 14:14:58	1.1.1.17
+++ typelib.c	2001/11/25 09:05:56
@@ -1739,6 +1743,7 @@
         pcx->pTblDir->pTypeInfoTab.offset+count*sizeof(tiBase));
 /* this is where we are coming from */
     ptiRet->pTypeLib = pLibInfo;
+    ITypeLib2_AddRef((ITypeLib2 *)pLibInfo);
     ptiRet->index=count;
 /* fill in the typeattr fields */
     FIXME("Assign constructor/destructor memid\n");
@@ -2876,6 +2881,7 @@
       }
       *ppTypeInfoImpl = (ITypeInfoImpl*)ITypeInfo_Constructor();
       (*ppTypeInfoImpl)->pTypeLib = pTypeLibImpl;
+	  ITypeLib2_AddRef((ITypeLib2 *)pTypeLibImpl);
       (*ppTypeInfoImpl)->index = i;
       (*ppTypeInfoImpl)->Name = TLB_MultiByteToBSTR(
    				     pOtherTypeInfoBlks[i].name_offs +
@@ -4198,7 +4204,7 @@
    if(!pRefType)
      FIXME("Can't find pRefType for ref %lx\n", hRefType);
    if(pRefType && hRefType != -1) {
-            ITypeLib *pTLib;
+            ITypeLib *pTLib = NULL;

if(pRefType->pImpTLInfo == TLB_REF_INTERNAL) {
            int Index;
@@ -4237,6 +4243,8 @@
    	    result = ITypeLib2_GetTypeInfo(pTLib, pRefType->index,
    					   ppTInfo);
        }
+	    if (pTLib != NULL)
+		ITypeLib2_Release(pTLib);
    }
     }

On Sun, 25 Nov 2001, Ove Kaaven wrote:
> I've explained it before on this list - you need to apply a typelib
> refcounting patch, and there is one by Malte somewhere in the wine-patches

Yes, I see you did, now I know to look for it.
> archives. But since you ask, here is the refcounting pieces of the patch
> we use in WineX:

Sorry, I thought that was in the cvs already.  Thanks!

Lawson