[RFC] advapi32 -- GetNamedSecurityInfo

[GOUJON Alexandre]

Hi,

I'm trying to fix bug 18071 but I don't know anything about ACLs.
I wrote some tests (see attached patch and 
https://testbot.winehq.org/JobDetails.pl?Key=2442)
and I modified the source according to my understanding of the issue 
(wich may be totally wrong).

But as I'm not familiar with ACLs and because my changes are quite 
important, I'm sending here my patches hoping a advapi32 coder could 
have a look at it.

Thanks in advance

[RFC] advapi32 -- GetNamedSecurityInfo

[Austin English]

On Thu, Jun 3, 2010 at 7:57 AM, GOUJON Alexandre  wrote:
> Hi,
>
> I'm trying to fix bug 18071 but I don't know anything about ACLs.
> I wrote some tests (see attached patch and
> https://testbot.winehq.org/JobDetails.pl?Key=2442)
> and I modified the source according to my understanding of the issue (wich
> may be totally wrong).

When testing LastError, you need to set it first to a known value, to
ensure that the test is really resetting LastError.

Most tests use
SetLastError(0xdeadbeef);

to do this.

[RFC] advapi32 -- GetNamedSecurityInfo

[Austin English]

On Thu, Jun 3, 2010 at 10:39 AM, Austin English  wrote:
> On Thu, Jun 3, 2010 at 7:57 AM, GOUJON Alexandre  wrote:
> > Hi,
> >
> > I'm trying to fix bug 18071 but I don't know anything about ACLs.
> > I wrote some tests (see attached patch and
> > https://testbot.winehq.org/JobDetails.pl?Key=2442)
> > and I modified the source according to my understanding of the issue (wich
> > may be totally wrong).
>
> When testing LastError, you need to set it first to a known value, to
> ensure that the test is really resetting LastError.
>
> Most tests use
> SetLastError(0xdeadbeef);

Sorry, misread your patch, ignore that comment.