[PATCH] ntdll: Add stub for NtContinue.

[Alistair Leslie-Hughes]

From: Michael Müller

Signed-off-by: Alistair Leslie-Hughes 
---
 dlls/ntdll/exception.c | 10 ++++++++++
 dlls/ntdll/ntdll.spec  |  4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/dlls/ntdll/exception.c b/dlls/ntdll/exception.c
index f853810..2887d69 100644
--- a/dlls/ntdll/exception.c
+++ b/dlls/ntdll/exception.c
@@ -306,6 +306,16 @@ ULONG WINAPI RtlRemoveVectoredExceptionHandler( PVOID handler )
 }

+/*********************************************************************
+ *         NtContinue   (NTDLL.@)
+ */
+NTSTATUS WINAPI NtContinue( CONTEXT *context, BOOLEAN alert )
+{
+    FIXME( "(%p, %d) stub!\n", context, alert );
+    return STATUS_NOT_IMPLEMENTED;
+}
+
+
 /*************************************************************
  *            __wine_spec_unimplemented_stub
  *
diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec
index 0107932..dd3d228 100644
--- a/dlls/ntdll/ntdll.spec
+++ b/dlls/ntdll/ntdll.spec
@@ -128,7 +128,7 @@
 @ stdcall NtCompleteConnectPort(ptr)
 # @ stub NtCompressKey
 @ stdcall NtConnectPort(ptr ptr ptr ptr ptr ptr ptr ptr)
-@ stub NtContinue
+@ stdcall NtContinue(ptr long)
 # @ stub NtCreateDebugObject
 @ stdcall NtCreateDirectoryObject(ptr long ptr)
 @ stdcall NtCreateEvent(ptr long ptr long long)
@@ -1058,7 +1058,7 @@
 @ stdcall -private ZwCompleteConnectPort(ptr) NtCompleteConnectPort
 # @ stub ZwCompressKey
 @ stdcall -private ZwConnectPort(ptr ptr ptr ptr ptr ptr ptr ptr) NtConnectPort
-@ stub ZwContinue
+@ stdcall -private ZwContinue(ptr long) NtContinue
 # @ stub ZwCreateDebugObject
 @ stdcall -private ZwCreateDirectoryObject(ptr long ptr) NtCreateDirectoryObject
 @ stdcall -private ZwCreateEvent(ptr long ptr long long) NtCreateEvent

[Alexandre Julliard]

Alistair Leslie-Hughes  writes:
> From: Michael Müller
> Signed-off-by: Alistair Leslie-Hughes
>
> dlls/ntdll/exception.c | 10 ++++++++++
>  dlls/ntdll/ntdll.spec  |  4 ++--
>  2 files changed, 12 insertions(+), 2 deletions(-)

Is this really fixing an app?  I wouldn't expect the app to be able to
cope with the function returning to the caller.

[Alistair Leslie-Hughes]

On 03/04/18 20:07, Alexandre Julliard wrote:
> Alistair Leslie-Hughes  writes:
> > From: Michael Müller
> > Signed-off-by: Alistair Leslie-Hughes
> >
> > dlls/ntdll/exception.c | 10 ++++++++++
> >  dlls/ntdll/ntdll.spec  |  4 ++--
> >  2 files changed, 12 insertions(+), 2 deletions(-)
>
> Is this really fixing an app?  I wouldn't expect the app to be able to
> cope with the function returning to the caller.

Not that I know of.  Here is a bug reference
https://bugs.winehq.org/show_bug.cgi?id=31910

I guess NtContinue will need a proper implementation.

Alistair.

[Alexandre Julliard]

Alistair Leslie-Hughes  writes:
> On 03/04/18 20:07, Alexandre Julliard wrote:
> > Alistair Leslie-Hughes  writes:
> > > From: Michael Müller
> > > Signed-off-by: Alistair Leslie-Hughes
> > >
> > > dlls/ntdll/exception.c | 10 ++++++++++
> > >  dlls/ntdll/ntdll.spec  |  4 ++--
> > >  2 files changed, 12 insertions(+), 2 deletions(-)
> >
> > Is this really fixing an app?  I wouldn't expect the app to be able to
> > cope with the function returning to the caller.
>
> Not that I know of.  Here is a bug reference
> https://bugs.winehq.org/show_bug.cgi?id=31910
>
> I guess NtContinue will need a proper implementation.

If some real app is calling it, sure. A stub KiUserExceptionDispatcher
doesn't qualify, particularly since there are better ways of
implementing it.