Re: Stubs in PE build

[Jon Griffiths]

Hi,

I had a patch which enabled stub generation for building native dlls
last year
(http://www.winehq.org/hypermail/wine-patches/2003/07/0176.html),
that part was not accepted for the same reasons that are being
mentioned in this thread.

I would like to point out again that the VC linker will not generate
a correct dll unless the ordinal stubs are present. Other native
linkers may have the same problem. It seems very silly to me that we
can't use M$'s own compiler/linker to build valid dlls (especially
since these tools can be downloaded for free these days). M$ defined
the dll format we are using, after all.

If this is intentional, perhaps we should document it somewhere?

Cheers,
Jon

=====
"Don't wait for the seas to part, or messiahs to come;
 Don't you sit around and waste this chance..." - Live

[e-mail]

__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - Get yours free! 
http://my.yahoo.com

Stubs in PE build

[Steven Edwards]

Hi Jon,

--- Jon Griffiths  wrote:
> I would like to point out again that the VC linker will not generate
> a correct dll unless the ordinal stubs are present. Other native
> linkers may have the same problem. It seems very silly to me that we
> can't use M$'s own compiler/linker to build valid dlls (especially
> since these tools can be downloaded for free these days). M$ defined
> the dll format we are using, after all.

Is there anyway we could add some magic to msvcmaker to do this? It seems
to me that if we need to have the stubs defined in a source file on msvc 
we can have msvcmaker parse the spec files and generate a extra source 
file when its making the makefiles.

Thanks
Steven

__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250

Stubs in PE build

[Jon Griffiths]

Hi,
> Is there anyway we could add some magic to msvcmaker to do this? It
> seems to me that if we need to have the stubs defined in a source
> file on msvc we can have msvcmaker parse the spec files and 
> generate a extra source file when its making the makefiles.

If Alexandre will accept patches to add the stubs as dummy functions,
we won't need to do this, I will generate + submit the stubs.

Cheers,
Jon

=====
"Don't wait for the seas to part, or messiahs to come;
 Don't you sit around and waste this chance..." - Live

[e-mail]

__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - What will yours do?
http://my.yahoo.com

Stubs in PE build

[Alexandre Julliard]

Jon Griffiths  writes:
> I would like to point out again that the VC linker will not generate
> a correct dll unless the ordinal stubs are present. Other native
> linkers may have the same problem. It seems very silly to me that we
> can't use M$'s own compiler/linker to build valid dlls (especially
> since these tools can be downloaded for free these days). M$ defined
> the dll format we are using, after all.

Yes, that's exactly why we need to get rid of stubs; there is no such
concept on Windows. The solution is not to start building a .spec.c
file for MSVC, it's to fix our spec files so that they can work on
Windows without generating extra code. This means replacing the stubs
by real functions.

Stubs in PE build

[Jon Griffiths]

Hi,
> The solution is not to start building a .spec.c
> file for MSVC, it's to fix our spec files so that they can work on
> Windows without generating extra code. This means replacing the
> stubs by real functions.

So will you accept patches to do this (add empty stubs)? winedump has
had the capacity to auto-generate these functions for _ages_.

Cheers,
Jon

=====
"Don't wait for the seas to part, or messiahs to come;
 Don't you sit around and waste this chance..." - Live

[e-mail]

__________________________________ 
Do you Yahoo!? 
Send holiday email and support a worthy cause. Do good. 
http://celebrity.mail.yahoo.com

Stubs in PE build

[Alexandre Julliard]

Jon Griffiths  writes:
> So will you accept patches to do this (add empty stubs)? winedump has
> had the capacity to auto-generate these functions for _ages_.

I certainly don't want to add 5000 auto-generated stubs. Now if you
want to use winedump to help you write stubs for the cases that are
really necessary (like ordinal exports) sure, but each stub needs to
be reviewed to make sure the return value etc. are correct.

Stubs in PE build

[Jon Griffiths]

--- Alexandre Julliard  wrote:
> I certainly don't want to add 5000 auto-generated stubs. Now if you
> want to use winedump to help you write stubs for the cases that are
> really necessary (like ordinal exports) sure, but each stub needs
> to
> be reviewed to make sure the return value etc. are correct.

For shlwapi there are 174 ordinal exports (currently stubs) that need
to be present in order for msvc's link.exe to generate a correct dll.
Its going to take a very long time to verify all of them, but I'll
see if I can make a start.

Cheers,
Jon

=====
"Don't wait for the seas to part, or messiahs to come;
 Don't you sit around and waste this chance..." - Live

[e-mail]

__________________________________ 
Do you Yahoo!? 
Meet the all-new My Yahoo! - Try it today! 
http://my.yahoo.com