d3dx: should NULL defines be accepted?

[Luis Busquets]

The current code for the functions:

D3DXCreateEffectFromFileExW  http://source.winehq.org/ident?i=D3DXCreateEffectFromFileExW
D3DXCreateEffectFromFileExA  http://source.winehq.org/ident?i=D3DXCreateEffectFromFileExA
D3DXCreateEffectFromResourceExW  http://source.winehq.org/ident?i=D3DXCreateEffectFromResourceExA
D3DXCreateEffectFromResourceExA  http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileW
D3DXCreateEffectCompilerFromFileW  http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileW
D3DXCreateEffectCompilerFromFileA  http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileA

includes a check of defines and will returnD3DERR_INVALIDCALL  http://source.winehq.org/ident?i=D3DERR_INVALIDCALL  if defines are NULL.

However I see nothing wrong in calling any of those functions with defines  being NULL. Actually, usually defines are NULL and it is only in specific cases when they are set.

Is this a bug? If not, please let me know why.

regards,

[Dmitry Timoshkov]

Luis Busquets  wrote:
> However I see nothing wrong in calling any of those functions with defines
> being NULL. Actually, usually defines are NULL and it is only in specific
> cases when they are set.
>
> Is this a bug? If not, please let me know why.

Write a test case?