Signed-off-by: Nikolay Sivov nsivov@codeweavers.com --- dlls/urlmon/tests/uri.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tests/uri.c index 64b6c56d4a..9069a9c176 100644 --- a/dlls/urlmon/tests/uri.c +++ b/dlls/urlmon/tests/uri.c @@ -8366,6 +8366,7 @@ static void test_IUri_GetPropertyLength(void) { /* Value may be unicode encoded */ expectedValueW = a2w(prop.value); expectedLen = lstrlenW(expectedValueW); + heap_free(expectedValueW);
/* This won't be necessary once GetPropertyLength is implemented. */ receivedLen = -1; @@ -11538,6 +11539,7 @@ static void test_IPersistStream(void) ok(hr == S_OK, "%d) Error creating uninitialized Uri: 0x%08x.\n", i, hr); hr = IUri_QueryInterface(uri, &IID_IMarshal, (void**)&marshal); ok(hr == S_OK, "%d) QueryInterface failed 0x%08x, expected S_OK.\n", i, hr); + IUri_Release(uri); hr = IMarshal_UnmarshalInterface(marshal, stream, &IID_IUri, (void**)&uri); ok(hr == S_OK, "%d) UnmarshalInterface failed 0x%08x, expected S_OK.\n", i, hr); hr = IUri_GetRawUri(uri, &raw_uri);
Signed-off-by: Nikolay Sivov nsivov@codeweavers.com --- dlls/shell32/tests/shlfolder.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index bb303f66e4..beee31f2ca 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dlls/shell32/tests/shlfolder.c @@ -5165,6 +5165,8 @@ static void test_GetDefaultColumn(void) hr = IShellFolder2_GetDefaultColumn(folder, 0, &sort, NULL); ok(hr == E_NOTIMPL, "Unexpected hr %#x.\n", hr); ok(sort == 123, "Unexpected default column.\n"); + + IShellFolder2_Release(folder); }
CoUninitialize();
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=45736
Your paranoid android.
=== w2003std (32 bit report) ===
shell32: shlfolder.c:4955: Test failed: MKDIR: Expected wndproc to be called shlfolder.c:4867: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 8) shlfolder.c:4955: Test failed: CREATE: Expected wndproc to be called shlfolder.c:4867: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) shlfolder.c:4955: Test failed: RMDIR: Expected wndproc to be called shlfolder.c:4867: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 10) shlfolder.c:4955: Test failed: MKDIR: Expected wndproc to be called shlfolder.c:4867: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 6ac) shlfolder.c:4955: Test failed: CREATE: Expected wndproc to be called shlfolder.c:4867: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 6ac) shlfolder.c:4955: Test failed: RMDIR: Expected wndproc to be called shlfolder.c:4867: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 6ac)
Signed-off-by: Nikolay Sivov nsivov@codeweavers.com --- dlls/combase/tests/roapi.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/dlls/combase/tests/roapi.c b/dlls/combase/tests/roapi.c index 05581f8948..eef00fcc8b 100644 --- a/dlls/combase/tests/roapi.c +++ b/dlls/combase/tests/roapi.c @@ -99,6 +99,7 @@ static void test_ActivationFactories(void) if(inspect) IInspectable_Release(inspect);
+ pWindowsDeleteString(str2); pWindowsDeleteString(str); pRoUninitialize(); }
Signed-off-by: Nikolay Sivov nsivov@codeweavers.com --- dlls/dwrite/tests/font.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/dwrite/tests/font.c b/dlls/dwrite/tests/font.c index aa1562ee32..3f4128986c 100644 --- a/dlls/dwrite/tests/font.c +++ b/dlls/dwrite/tests/font.c @@ -8887,6 +8887,8 @@ static void test_localfontfileloader(void) IDWriteFontFileLoader_Release(loader2); ref = IDWriteFactory_Release(factory); ok(ref == 0, "factory not released, %u\n", ref); + ref = IDWriteFactory_Release(factory2); + ok(ref == 0, "factory not released, %u\n", ref); DELETE_FONTFILE(path); }
Signed-off-by: Nikolay Sivov nsivov@codeweavers.com --- dlls/oledb32/tests/convert.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/dlls/oledb32/tests/convert.c b/dlls/oledb32/tests/convert.c index 441624048a..5dab9ff31e 100644 --- a/dlls/oledb32/tests/convert.c +++ b/dlls/oledb32/tests/convert.c @@ -3786,6 +3786,7 @@ static void test_converttonumeric(void) todo_wine ok(dst_status == DBSTATUS_S_OK, "got %08x\n", dst_status); todo_wine ok(dst_len == sizeof(dst), "got %ld\n", dst_len); todo_wine test_numeric_val(&dst, &result5); + SysFreeString(bstr);
bstr = SysAllocString(largeW); dst_status = 0; @@ -3798,6 +3799,7 @@ static void test_converttonumeric(void) todo_wine ok(dst_status == DBSTATUS_S_OK, "got %08x\n", dst_status); todo_wine ok(dst_len == sizeof(dst), "got %ld\n", dst_len); todo_wine test_numeric_val(&dst, &result6); + SysFreeString(bstr); }
START_TEST(convert)
Signed-off-by: Nikolay Sivov nsivov@codeweavers.com --- dlls/msxml3/domdoc.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index 445caaee69..76d3fdb601 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -2292,8 +2292,8 @@ static HRESULT WINAPI domdoc_load(
if ( filename ) { + IUri *uri = NULL; IMoniker *mon; - IUri *uri;
if (This->properties->uri) { @@ -2310,15 +2310,19 @@ static HRESULT WINAPI domdoc_load( IMoniker_Release(mon); }
- if ( FAILED(hr) ) - This->error = E_FAIL; - else + if (SUCCEEDED(hr)) { get_doc(This)->name = (char *)xmlchar_from_wcharn(filename, -1, TRUE); This->properties->uri = uri; hr = This->error = S_OK; *isSuccessful = VARIANT_TRUE; } + else + { + if (uri) + IUri_Release(uri); + This->error = E_FAIL; + } }
if(!filename || FAILED(hr)) {
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=45732
Your paranoid android.
=== debian9 (64 bit WoW report) ===
msxml3: Unhandled exception: page fault on execute access to 0x0003b470 in 64-bit code (0x000000000003b470).
On 12/17/18 8:36 AM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=45732
Your paranoid android.
=== debian9 (64 bit WoW report) ===
msxml3: Unhandled exception: page fault on execute access to 0x0003b470 in 64-bit code (0x000000000003b470).
This one is not new, it crashes on one machine consistently according to the test page.
-
Jacek Caban -
Marvin -
Nikolay Sivov