Re: mscoree [1/2]: Add missing stubs to the spec file

[Paul Chitescu]

On Wed, 11 Oct 2006, James Hawkins wrote:
> Hi,
>
> Changelog:
> - Add missing stubs to the spec file.
>
> dlls/mscoree/mscoree.spec |  125 +++++++++++++++++++++++++++++++++++++++++++--
>  1 files changed, 120 insertions(+), 5 deletions(-)

Interesting - what mscoree version are those ordinals from? I got mines 
from XP Home SP2.

Paul Chitescu

mscoree [1/2]: Add missing stubs to the spec file

[James Hawkins]

On 10/11/06, Paul Chitescu  wrote:
> On Wed, 11 Oct 2006, James Hawkins wrote:
> > Hi,
> >
> > Changelog:
> > - Add missing stubs to the spec file.
> >
> > dlls/mscoree/mscoree.spec |  125 +++++++++++++++++++++++++++++++++++++++++++--
> >  1 files changed, 120 insertions(+), 5 deletions(-)
>
> Interesting - what mscoree version are those ordinals from? I got mines
> from XP Home SP2.

XP Professional SP2.  I'm pretty sure your copy of mscoree.dll doesn't
have just those exports.  Send it to me off the list and I'll check it
out.

mscoree [1/2]: Add missing stubs to the spec file

[James Hawkins]

On 10/11/06, James Hawkins  wrote:
> On 10/11/06, Paul Chitescu  wrote:
> > On Wed, 11 Oct 2006, James Hawkins wrote:
> > > Hi,
> > >
> > > Changelog:
> > > - Add missing stubs to the spec file.
> > >
> > > dlls/mscoree/mscoree.spec |  125 +++++++++++++++++++++++++++++++++++++++++++--
> > >  1 files changed, 120 insertions(+), 5 deletions(-)
> >
> > Interesting - what mscoree version are those ordinals from? I got mines
> > from XP Home SP2.
>
> XP Professional SP2.  I'm pretty sure your copy of mscoree.dll doesn't
> have just those exports.  Send it to me off the list and I'll check it
> out.

Ah ordinals, for this dll it's not a big deal because (probably) all
apps get the export by name instead of ordinal.  For the installers
I've seen that's the case, and I can't imagine any app working on both
Home and Professional if the ordinals are different and they call
GetProcAddress with the ordinals.

mscoree [1/2]: Add missing stubs to the spec file

[Dmitry Timoshkov]

"James Hawkins"  wrote:
> Ah ordinals, for this dll it's not a big deal because (probably) all
> apps get the export by name instead of ordinal.  For the installers
> I've seen that's the case, and I can't imagine any app working on both
> Home and Professional if the ordinals are different and they call
> GetProcAddress with the ordinals.

According to 'dumpbin /exports mscoree.lib' on a mscoree.lib from PSDK
only a few exports really have an ordinal assigned: some C++ ones and
ReOpenMetaDataWithMemory (23).

mscoree [1/2]: Add missing stubs to the spec file

[James Hawkins]

On 10/11/06, Dmitry Timoshkov  wrote:
> "James Hawkins"  wrote:
> > Ah ordinals, for this dll it's not a big deal because (probably) all
> > apps get the export by name instead of ordinal.  For the installers
> > I've seen that's the case, and I can't imagine any app working on both
> > Home and Professional if the ordinals are different and they call
> > GetProcAddress with the ordinals.
>
> According to 'dumpbin /exports mscoree.lib' on a mscoree.lib from PSDK
> only a few exports really have an ordinal assigned: some C++ ones and
> ReOpenMetaDataWithMemory (23).

Is this information available in our winedump?  I've always been
confused about when to use ordinals and whent to use the @ symbol.  I
also used depends and that just gave me the ordinals.

mscoree [1/2]: Add missing stubs to the spec file

[Dmitry Timoshkov]

"James Hawkins"  wrote:
> Is this information available in our winedump?  I've always been
> confused about when to use ordinals and whent to use the @ symbol.  I
> also used depends and that just gave me the ordinals.

No, winedump is not able to dump contents of COFF .lib files, and
PE files don't provide information about real ordinal numbers.

mscoree [1/2]: Add missing stubs to the spec file

[Dmitry Timoshkov]

"James Hawkins"  wrote:
> > "James Hawkins"  wrote:
> > > Ah ordinals, for this dll it's not a big deal because (probably) all
> > > apps get the export by name instead of ordinal.  For the installers
> > > I've seen that's the case, and I can't imagine any app working on both
> > > Home and Professional if the ordinals are different and they call
> > > GetProcAddress with the ordinals.
> >
> > According to 'dumpbin /exports mscoree.lib' on a mscoree.lib from PSDK
> > only a few exports really have an ordinal assigned: some C++ ones and
> > ReOpenMetaDataWithMemory (23).
>
> Is this information available in our winedump?  I've always been
> confused about when to use ordinals and whent to use the @ symbol.  I
> also used depends and that just gave me the ordinals.

I've sent a patch for winedump which adds a COFF library dumper functionality
to it. It hasn't been committed due to some minor problems with it (missing
auto-detection of a file format), but any interested person should be able
to apply it and start a janitorial work of inspecting/fixing/synchronizing
ordinal exports between Wine and Windows using information from the PSDK
import libraries.

mscoree [1/2]: Add missing stubs to the spec file

[James Hawkins]

On 11/27/06, Dmitry Timoshkov  wrote:
> "James Hawkins"  wrote:
> > > "James Hawkins"  wrote:
> > > > Ah ordinals, for this dll it's not a big deal because (probably) all
> > > > apps get the export by name instead of ordinal.  For the installers
> > > > I've seen that's the case, and I can't imagine any app working on both
> > > > Home and Professional if the ordinals are different and they call
> > > > GetProcAddress with the ordinals.
> > >
> > > According to 'dumpbin /exports mscoree.lib' on a mscoree.lib from PSDK
> > > only a few exports really have an ordinal assigned: some C++ ones and
> > > ReOpenMetaDataWithMemory (23).
> >
> > Is this information available in our winedump?  I've always been
> > confused about when to use ordinals and whent to use the @ symbol.  I
> > also used depends and that just gave me the ordinals.
>
> I've sent a patch for winedump which adds a COFF library dumper functionality
> to it. It hasn't been committed due to some minor problems with it (missing
> auto-detection of a file format), but any interested person should be able
> to apply it and start a janitorial work of inspecting/fixing/synchronizing
> ordinal exports between Wine and Windows using information from the PSDK
> import libraries.

Thanks for these patches Dmitry!  I'll try it out.

mscoree [1/2]: Add missing stubs to the spec file

[Dmitry Timoshkov]

"James Hawkins"  wrote:
> Thanks for these patches Dmitry!  I'll try it out.

Please take into account that the only patch you need and which
hasn't been committed is the [6/6] one.