Re: [PATCH 1/7] d3drm: Use CreateObject in IDirect3DRM*::LoadTexture. (v2)

[Aaryaman Vasishta]

On Thu, May 19, 2016 at 4:25 PM, Aaryaman Vasishta <
[e-mail]> wrote:
> v2: Thunk 2->3 for LoadTexture.
> Signed-off-by: Aaryaman Vasishta
>
> dlls/d3drm/d3drm.c | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c
> index edb46df..bc16b6f 100644
> --- a/dlls/d3drm/d3drm.c
> +++ b/dlls/d3drm/d3drm.c
> @@ -413,16 +413,13 @@ static HRESULT WINAPI
> d3drm1_CreateUserVisual(IDirect3DRM *iface,
>  static HRESULT WINAPI d3drm1_LoadTexture(IDirect3DRM *iface,
>          const char *filename, IDirect3DRMTexture **texture)
>  {
> -
>
> struct d3drm_texture *object;
> HRESULT hr;
>
> FIXME("iface %p, filename %s, texture %p stub!\n", iface,
>
> debugstr_a(filename), texture);
> - if (FAILED(hr = d3drm_texture_create(&object)))
> - if (FAILED(hr = IDirect3DRM_CreateObject(iface,
>
> &CLSID_CDirect3DRMTexture, NULL, &IID_IDirect3DRMTexture, (void
> **)texture)))
>          return hr;

This line is too long, I'm resending v3 of this patch.

Cheers,
Aaryaman