Re: reg: Implement binary data add operation

[Alexandre Julliard]

Thomas Faller  writes:
> +static inline BOOL is_xp_or_older(void)
> +{
> - DWORD version = GetVersion();
> - if(version < 0x80000000){
> -
>    /* compare major */
> -
>    return (DWORD)(LOBYTE(LOWORD(version))) < 6;
> - }
> - return TRUE;
>
> +}

Do you actually have an app that depends on such a version check?

reg: Implement binary data add operation

[Thomas Faller]

No, i don't know an app which needs this.
But this special case is noticed in the reg.exe tests, so I decided to 
implement the version check.

Kind Regards
Thomas

Am 03.09.2015 um 10:55 schrieb Alexandre Julliard:
> Thomas Faller  writes:
> > +static inline BOOL is_xp_or_older(void)
> > +{
> > - DWORD version = GetVersion();
> > - if(version < 0x80000000){
> > -
> >    /* compare major */
> > -
> >    return (DWORD)(LOBYTE(LOWORD(version))) < 6;
> > - }
> > - return TRUE;
> >
> > +}
>
> Do you actually have an app that depends on such a version check?

reg: Implement binary data add operation

[Alexandre Julliard]

Thomas Faller  writes:
> No, i don't know an app which needs this.
> But this special case is noticed in the reg.exe tests, so I decided to
> implement the version check.

You shouldn't do a version check. Simply implement the new behavior
since the old one is already marked as broken.