Re: [PATCH] quartz: Handle NULL target format in FilterGraph::ConvertTimeFormat.

[Nikolay Sivov]

On 05.01.2016 14:13, Anton Baskanov wrote:
> Signed-off-by: Anton Baskanov
>
> dlls/quartz/filtergraph.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
> index 5b4b080..5cb670e 100644
> --- a/dlls/quartz/filtergraph.c
> +++ b/dlls/quartz/filtergraph.c
> @@ -2530,6 +2530,9 @@ static HRESULT WINAPI MediaSeeking_ConvertTimeFormat(IMediaSeeking *iface, LONGL
>      if (!pSourceFormat)
>          pSourceFormat = &This->timeformatseek;
> - if (!pTargetFormat)
> -
>    pTargetFormat = &This->timeformatseek;
> - if (IsEqualGUID(pTargetFormat, pSourceFormat))
>        *pTarget = Source;
>    else

Hi, Anton.

According to msdn this looks correct to me. Could you add a simple test
for that? Let's say one test with both formats as NULL; and a couple
more with one format being NULL and another set to current format.

Looks like it could be added easily to test_mediacontrol() as it has
everything you'd need.

[PATCH] quartz: Handle NULL target format in FilterGraph::ConvertTimeFormat.

[Anton Baskanov]

Hi,

Thanks for review, I've sent a new version.

On Wed, Jan 6, 2016 at 7:06 PM, Nikolay Sivov  wrote:
> On 05.01.2016 14:13, Anton Baskanov wrote:
> > Signed-off-by: Anton Baskanov
> >
> > dlls/quartz/filtergraph.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
> > index 5b4b080..5cb670e 100644
> > --- a/dlls/quartz/filtergraph.c
> > +++ b/dlls/quartz/filtergraph.c
> > @@ -2530,6 +2530,9 @@ static HRESULT WINAPI
>
> MediaSeeking_ConvertTimeFormat(IMediaSeeking *iface, LONGL
> >  if (!pSourceFormat)
> >      pSourceFormat = &This->timeformatseek;
> >
> > - if (!pTargetFormat)
> > -
> >    pTargetFormat = &This->timeformatseek;
> > - if (IsEqualGUID(pTargetFormat, pSourceFormat))
> >        *pTarget = Source;
> >    else
>
> Hi, Anton.
>
> According to msdn this looks correct to me. Could you add a simple test
> for that? Let's say one test with both formats as NULL; and a couple
> more with one format being NULL and another set to current format.
>
> Looks like it could be added easily to test_mediacontrol() as it has
> everything you'd need.