Re: kernel32: Set object security on process object in CreateProcess.[try2]

[Vitaliy Margolen]

Vitaliy Margolen wrote:
> Removed todo from succeeding tests.
>
> Tests showed that only DACL can be set this way. Owner and group
> are taken from the token. And we don't need SACL at this time if ever.
>
> dlls/advapi32/tests/security.c |    3 ---
>  dlls/kernel32/process.c        |   12 ++++++++++++
>  2 files changed, 12 insertions(+), 3 deletions(-)

Any reason this patch was not applied?

Vitaliy.

kernel32: Set object security on process object in CreateProcess.[try2]

[Alexandre Julliard]

Vitaliy Margolen  writes:
> Vitaliy Margolen wrote:
> > Removed todo from succeeding tests.
> >
> > Tests showed that only DACL can be set this way. Owner and group
> > are taken from the token. And we don't need SACL at this time if ever.
> >
> > dlls/advapi32/tests/security.c |    3 ---
> >  dlls/kernel32/process.c        |   12 ++++++++++++
> >  2 files changed, 12 insertions(+), 3 deletions(-)
>
> Any reason this patch was not applied?

There's a race, someone else could open the process before the
descriptor is set.