Re: Print warning when drives of type cdrom do not contain a device field

[Mike Hearn]

OK, so I forgot the changelog entry. Apart from that, any reason this
patch bounced?

On Tue, 13 Jan 2004 19:11:17 +0000, Mike Hearn wrote:
> I wasted half and hour tracing through the cdrom subsystem to find out why
> halflife wasn't playing any music, only to find it was a config file
> problem. Maybe this message can stop other people from making the same
> mistake.
> Index: files/drive.c
>
> RCS file: /home/wine/wine/files/drive.c,v
> retrieving revision 1.104
> diff -u -r1.104 drive.c
> --- files/drive.c       25 Nov 2003 01:51:07 -0000      1.104
> +++ files/drive.c       13 Jan 2004 19:01:13 -0000
> @@ -338,7 +338,9 @@
>                          close(cd_fd);
>                      }
>                  }
> -
>        }
> -
>        } else if (drive->type == DRIVE_CDROM) {
> -
>           MESSAGE("\n* You have a CD-ROM drive defined in your configuration, but it is missing the Device key.\n* Playing CD audio and direct access will  not work.\n\n");
> -
>       }
>
>        /* Get the FailReadOnly flag */
>        RtlInitUnicodeString( &nameW, FailReadOnlyW );

Print warning when drives of type cdrom do not contain a device field

[Alexandre Julliard]

Mike Hearn  writes:
> OK, so I forgot the changelog entry. Apart from that, any reason this
> patch bounced?

We obviously can't print warnings on the console for every config
parameter that might be wrong. That's a job for winecheck.

Print warning when drives of type cdrom do not contain a device field

[Mike Hearn]

On Wed, 2004-01-21 at 23:18, Alexandre Julliard wrote:
> We obviously can't print warnings on the console for every config
> parameter that might be wrong. That's a job for winecheck.

OK. Is there a reason this isn't autodetected anyway, or is that coming
up in Erics rewrite?

Print warning when drives of type cdrom do not contain a device field

[Eric Pouech]

Mike Hearn a écrit :
> On Wed, 2004-01-21 at 23:18, Alexandre Julliard wrote:
> > We obviously can't print warnings on the console for every config
> > parameter that might be wrong. That's a job for winecheck.
>
> OK. Is there a reason this isn't autodetected anyway, or is that coming
> up in Erics rewrite?

the plan is that all physical volumes and cdrom will have the correctly 
configured device (which can be overriden)
A+