Re: [PATCH 1/3] browseui: Add IOleWindow to IProgressDialog

[Michael Stefaniuc]

Hello Detlef,

On 04/15/2012 10:08 PM, Detlef Riekenberg wrote:
> Used by apps to adjust the dialog position
> or remove the cancel button before vista
>
> --
> By by ... Detlef
>
> dlls/browseui/progressdlg.c |   69 ++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 68 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/browseui/progressdlg.c b/dlls/browseui/progressdlg.c
> index 9b970e2..2807622 100644
> --- a/dlls/browseui/progressdlg.c
> +++ b/dlls/browseui/progressdlg.c
> @@ -270,9 +276,20 @@ static HRESULT WINAPI ProgressDialog_QueryInterface(IProgressDialog *iface, REFI
>      ProgressDialog *This = impl_from_IProgressDialog(iface);
>      *ppvOut = NULL;
> - if (IsEqualIID(iid, &IID_IUnknown) || IsEqualIID(iid, &IID_IProgressDialog))
> - if (IsEqualIID(iid, &IID_IUnknown))
> {
>     *ppvOut = This;
> -
>    TRACE("(%p, IID_IUnknown, %p) -> %p\n", This, ppvOut, This);
> - }
> - else if (IsEqualIID(iid, &IID_IProgressDialog))
> - {
> -
>    *ppvOut = This;

this is not correct as ppvOut takes an interface and not an object.
While at it please fix the above one too.

thanks
bye
    michael