Re: Bug #321: msvcrt-vfprintf-3.diff

[Dmitry Timoshkov]

"Jaco Greeff"  wrote:
> Ok, try number 3. I've made the changes as requested
> - Get result length before allocating and copying with WideCharToMultiByte;
> - Make intentions clear on strncat, replaced with strcat
> - Removed CHAR castings to get the WCHAR formatting character.
> - Fixes as requested by Dimitri and included in previous version;

You are still using L prefix and redundant (WCHAR) casts.

Instead of
if (*szFmt == (WCHAR)L'-')
and
case (WCHAR)L'd': ADD_FORMAT_TYPE(VFMT_INTEGER, "d");

simple
if (*szFmt == '-')
and
case 'd': ADD_FORMAT_TYPE(VFMT_INTEGER, "d");

will do the job.

Bug #321: msvcrt-vfprintf-3.diff

[Jaco Greeff]

Dmitry Timoshkov wrote:
> You are still using L prefix and redundant (WCHAR) casts.

I know, it makes it more readable for me at least, telling you exactly 
what you are busy with. As I've said previously, it is just semantics 
mostly on compile-time. Either way it doesn't make a real difference, 
altough I believe that with it it might be more "maintainable".

Anyway, expect a patch shortly without these :)

Greetings,
Jaco