Re: [4/5] secur32: Allocate schannel client credentials

[Rob Shearman]

2008/9/22 Henri Verbeet :
> @@ -47,6 +61,7 @@ struct schan_handle
>  struct schan_credentials
>  {
>      ULONG credential_use;
> - gnutls_certificate_credentials_t credentials;
>
> };
>
> static struct schan_handle *schan_handle_table;
> @@ -273,6 +288,7 @@ static SECURITY_STATUS schan_AcquireClientCredentials(const SCHANNEL_CRED *schan
>          }
>      creds->credential_use = SECPKG_CRED_OUTBOUND;
> -
>    pgnutls_certificate_allocate_credentials(&creds->credentials);
>
>    phCredential->dwLower = handle;
>    phCredential->dwUpper = 0;

You should check the return value from
gnutls_certificate_allocate_credentials, in case it fails and return a
failure code to the caller.