Re: crypt32: plug memory leaks

[Robert Shearman]

Juan Lang wrote:
> Hope you don't mind the memory function changes, they helped me debug the
> leaks.
>
> ChangeLog:
> - use macros for memory allocation for easier debugging
> - plug memory leaks

I'm not sure why you need to use these extra macros for memory 
allocation. Can't you simply replace the CryptMem* functions during 
debugging with a macro?

crypt32: plug memory leaks

[Juan Lang]

--- Robert Shearman  wrote:
> I'm not sure why you need to use these extra macros for memory 
> allocation. Can't you simply replace the CryptMem* functions during 
> debugging with a macro?

Not without an uglier hack, the CryptMem functions are exported.  I can
just define new versions of crypt_alloc et al with this.

--Juan

__________________________________ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

crypt32: plug memory leaks

[Robert Shearman]

Juan Lang wrote:
> --- Robert Shearman  wrote:
> > I'm not sure why you need to use these extra macros for memory 
> > allocation. Can't you simply replace the CryptMem* functions during 
> > debugging with a macro?
>
> Not without an uglier hack, the CryptMem functions are exported.  I can
> just define new versions of crypt_alloc et al with this.

You can still #define them to whatever you want in the header file, as 
long as you #undef them before the implementation of the CryptMem* 
functions and redefine them afterwards.

crypt32: plug memory leaks

[Dimi Paun]

On Tue, 2005-11-08 at 22:21 -0600, Robert Shearman wrote:
> You can still #define them to whatever you want in the header file, as
> long as you #undef them before the implementation of the CryptMem* 
> functions and redefine them afterwards.

Yeah, please do that, the additional level of indirection
is just too ugly.