Re: winex11.drv/wintab32[1/5]: store categories field-by-field (resend)

[Alexandre Julliard]

"Mikolaj Zalewski"  writes:
> /***********************************************************************
> -
> X11DRV_WTInfoA (X11DRV.@)
> -
> -
> -
> - NOTES
> -
> - If cchOnlyCountString is not NULL and the data is a string then no
> -
> - data is stored in the output buffer but only the string length is
> -
> - returned in *cchOnlyCountString (and is >= 1 as contains at least a NUL
> -
> - character). It have no effect on non-string data.
> -
> -
> -
> - Apart from the cchOnlyCountString parameter this function differs from the
> -
> - WTInfo[AW] as for nIndex == 0 it returns the number of items in the
> -
> - category. It's wintab32.dll that concatenates the data
> -
> -
> -
> - It is valid to call WTInfoA with lpOutput == NULL, as per standard.
> -
> - lpOutput == NULL signifies the user only wishes to find the size of
> -
> - the data.
> */
>
> -UINT X11DRV_WTInfoA(UINT wCategory, UINT nIndex, LPVOID lpOutput)
> +UINT X11DRV_WTInfoA(UINT wCategory, UINT nIndex, LPVOID lpOutput, DWORD *cchOnlyCountString)

You shouldn't change the prototype. Driver functions should follow the
signature of the corresponding APIs as far as possible.

winex11.drv/wintab32[1/5]: store categories field-by-field (resend)

[Mikolaj Zalewski]

> You shouldn't change the prototype. Driver functions should follow the
> signature of the corresponding APIs as far as possible.

There is a problem to have the same prototype and make winex11.drv
call handle only Unicode as some of the WTInfo output are binary data
and some are strings. Should I duplicate the knowledge of which are
which in wintab32?

Mikolaj Zalewski

winex11.drv/wintab32[1/5]: store categories field-by-field (resend)

[Alexandre Julliard]

"Mikolaj Zalewski"  writes:
> There is a problem to have the same prototype and make winex11.drv
> call handle only Unicode as some of the WTInfo output are binary data
> and some are strings. Should I duplicate the knowledge of which are
> which in wintab32?

The W->A translation in wintab32 of course needs to know the format of
the data to map strings correctly, that's not a problem.