Re: Add d3d11_CreateDeviceAndSwapChain

[Martell Malone]

Hi guys,

I updated the patch on wine-patches to reflect bruno's input on the commit
message and
I changed the %d to %u.

Thanks guys
Martell

On Tue, Feb 3, 2015 at 5:28 PM, Bruno Jesus  wrote:
> Hi, this is just a hint. You are not following the standards for the
> patch subject. If you see http://wiki.winehq.org/SubmittingPatches
> There is:
>
> If you are fixing a specific component or part, write the component's
> name followed by a colon:
>
> [1/2] msvcrt: First change...
> [2/2] msvcrt: Second change...
> wined3d: Separate change...
>
> Take a look at the patches list and you will see what I'm saying:
> http://source.winehq.org/patches/
>
> Best regards,
> Bruno
>
> On Tue, Feb 3, 2015 at 3:22 PM, Martell Malone 
> wrote:
> > D3D11CreateDevice also has "sdk_version %d"
> > I used that as a reference.
> > Does this mean that the other stub is wrong also ??
> >
> > On Tue, Feb 3, 2015 at 8:13 AM, Stefan Dösinger <
>
> [e-mail]>
> > wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Am 2015-02-02 um 20:24 schrieb Martell Malone:
> > > > - FIXME("stub: adapter %p, driver_type %s, swrast %p, flags
> > > >
> > > > %#x, feature_levels %p, levels %#x, sdk_version %d, "
> > >
> > > You're still printing sdk_version as a signed value. Please use %u
> > > instead of %d.
> > >
> > > Otherwise this looks good to me.
> > >
> > > -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v2
> > >
> > > iQIcBAEBAgAGBQJU0IM3AAoJEN0/YqbEcdMw5v8P/3A5kt9fIPCVCTgXfM0A6uKS
> > > 8cCXPITuKmeub7obw7EiEhsQH/4pw80bKOhmFKZvpK0knrKeU7wZvojbP18n39j1
> > > vVqpqvtzbkfsBwLZ/Z0AeC/evVACfMmw1Al3BMBTDhxFb+uv+rVI9spG06XRPx8P
> > > e3pWlzoGniaZG8YP6TguA0gfrcMcGWEOWT59nstWW0HXlMFdsE1OoMM5Wd+XrpB+
> > > AuEHGNFiHacgNxVfpnk6wQw5TK2uXW79ZbjX2wnrDiXkYvUZBts34Xo5cTdXNMXp
> > > DugbwLQtoC3Yu4rHxymjZTNbJLDY0bAOgBo4YwMCVnfLj7zbwvNABqtEIKtVs5Mx
> > > XsovTKzLD5sPmWnCxMtC5Qmz/aQebOYWF9bB3vYju876h69J5aJt4OjGU0HfLd4g
> > > 26uQEWgT+UbU0Lavofn3w9jcO4qEBl3NbmTs4egsw8n5Ry5f+N58BX1OdaOSdkmy
> > > a3Io6NgV48I/FjbxdlqpMz10I+06VlWiMdlmQSKxWTN1t5AxTm8/dTHLMC4+D7nn
> > > FOeWvOr3Wy4ocBWoOpT94etIBxut8IMfSHzEKsoll7kib3daYVDPv97pAbKdV3fT
> > > tZhzhWif+sqneVpk9QnCqhd9v9Kd29axqTBy7JiZ9t8TYxFTrXu50ZgC5oX/zKBV
> > > 4jVGoA2kY+Gtv9KR6SH0
> > > =R0+9
> > > -----END PGP SIGNATURE-----