Am 26.08.2008 um 16:46 schrieb Dan Kegel:
I updated http://wiki.winehq.org/SubmittingPatches with that info (and lots more, too)
The git sample commands there differ from the ones given in <http:// wiki.winehq.org/GitWine#head- f7a29e7ed999b5924748a60c5a1cd4a019032d26> by the --keep-subject flag. Which one would be the better one?
Citing the web page:
If your patch isn't committed in a day or two, improve it (perhaps by adding more tests) and resend. Or continue on with more changes, and send a longer patch series next time.
Judging by my recent experience, how about:
If your patch isn't committed in a day ot two, first have a look at the patchwatcher status page, wether your patch were approved. If it was, you might want to ask on the wine-devel mailing list on how it could be improved. Especially with your first patches, it might take a resend or two to get it accustomed to the Wine development process.
I'd avoid recommending longer patch series.
MarKus
- - - - - - - - - - - - - - - - - - - Dipl. Ing. Markus Hitter http://www.jump-ing.de/
On Tuesday 26 August 2008 18:15:27 Markus Hitter wrote:
Am 26.08.2008 um 16:46 schrieb Dan Kegel:
I updated http://wiki.winehq.org/SubmittingPatches with that info (and lots more, too)
The git sample commands there differ from the ones given in http:// wiki.winehq.org/GitWine#head- f7a29e7ed999b5924748a60c5a1cd4a019032d26 by the --keep-subject flag. Which one would be the better one?
--keep-subject. As it's in _most_ of the example calls on the GitWine page, I've fixed the last example.
--keep-subject keeps git format-patch from adding a [Patch] tag on your subject line. As all emails to wine-patches are supposedly patches, so a patch tag is kind of pointless.
Cheers, Kai
-
Kai Blin -
Markus Hitter