Re: d3d8: Dangling pointers fix

[Stefan Dösinger]

Am Montag, 5. Mai 2008 17:42:51 schrieb Andrew Talbot:
> I have moved the TRACEs to where I think they belong. Please give feedback
> if this patch is incorrect.

on a quick look it looks OK. Did you check if any output is written in the 
case of failures in those functions?

d3d8: Dangling pointers fix

[Andrew Talbot]

Stefan Dösinger wrote:
> Am Montag, 5. Mai 2008 17:42:51 schrieb Andrew Talbot:
> > I have moved the TRACEs to where I think they belong. Please give
> > feedback if this patch is incorrect.
>
> on a quick look it looks OK. Did you check if any output is written in the
> case of failures in those functions?

Hi Stefan,

I only took a static look at the code for those functions and checked that
each code path that would lose its "TRACE" would still have a "WARN" or
a "FIXME". I just wasn't sure if this was acceptable, or whether we really
do need two debug message for such a case.