On Monday 14 October 2002 13:03, Uwe Bonnes wrote:
The patch mostly removes stuff. What substitutes the replaces stuff? Please explain.
Last week I downloaded the current wine version. I was a bit surprised, when noticing, my winefile implementation of 2000 has been finally included in the packet. :-)
So I tried it - and found a few bugs. Now I want to remove them.
The Resources in "rsrc.rc" are duplicate. You can find the same in the file "resource.rc" (IDB_TOOLBAR, IDB_DRIVEBAR, ...). So I just removed one instance.
The changes in "winefile.c":
It seems, there was introduced a bug, when including winefile in the wine source tree. There eas removed the C++-style struct-initialisation, and replaced by C-style initialisation. The little difference is: My orginal code did set any not explicitely initialialised member of DRAWITEMSTRUCT to zero. The patch now re-includes this. (in C-style)
The last few changes are for being able to compile the code with VC++ under native WIN32. This compiler needs the include file <malloc.h> for declaration of alloca().
[If you want to compile it with VC++, you need some more files: drivebar.bmp, images.bmp, toolbar.bmp, winefile.ico, winefile.dsp, winefile.dsw]
Cheers,
Martin
Hello Martin,
Last week I downloaded the current wine version. I was a bit surprised, when noticing, my winefile implementation of 2000 has been finally included in the packet. :-)
I resubmitted your Winefile code because I wanted to use it on the ReactOS project and I knew you really wanted it included in the wine tree. I have tried to email you a few times over the past year but always got bounced messages back. Good to hear you are still around.
[If you want to compile it with VC++, you need some more files: drivebar.bmp, images.bmp, toolbar.bmp, winefile.ico, winefile.dsp, winefile.dsw]
I have not tried yet but Patrik has been working on the MS_VC port of WINE so fixing Winefile for MS_VC is needed. You can either feed the WINE resources to wrc then to the Windows resource compiler or you can convert the WINE resources back to normal binary bitmaps using bin2res.
Feature request: get double click launching working =)
Thanks Steven
__________________________________________________ Do you Yahoo!? Faith Hill - Exclusive Performances, Videos & More http://faith.yahoo.com
Hello Steven!
I resubmitted your Winefile code because I wanted to use it on the ReactOS project and I knew you really wanted it included in the wine tree. I have tried to email you a few times over the past year but always got bounced messages back. Good to hear you are still around.
Mmmh - did you use the correct address?
[If you want to compile it with VC++, you need some more files: drivebar.bmp, images.bmp, toolbar.bmp, winefile.ico, winefile.dsp, winefile.dsw]
I have not tried yet but Patrik has been working on the MS_VC port of WINE so fixing Winefile for MS_VC is needed. You can either feed the WINE resources to wrc then to the Windows resource compiler or you can convert the WINE resources back to normal binary bitmaps using bin2res.
Since I converted the resource files in the opposite direction - from windows to wine, I already have the files. If you're interested: I have attached a archive containing them. In fact, I wrote most of the program using the MSDEV IDE, and then ported it to wine.
Feature request: get double click launching working =)
I think, this will not be too difficult. Calling ShellExecute() should do the trick. (Supposing ShellExecute already works ;-) I will try to implement the feature.
Cheers,
Martin
Hi again!
To implement program launching really was not difficult. However FormatMessage() seems not to work properly. When trying to retreive system error strings, nothing is returned in the string buffer. So the message box doesn't display a usefull error message.
Cheers,
Martin
-
Martin Fuchs -
Steven Edwards