"Roderick Colenbrander" thunderbird2k@gmx.net wrote:
This patch creates an X11 window for the client area. The code is inspired by old x11drv of which even a few pieces got copied over. Further Chris Robinson assisted with positioning issues.
After this patch most remnants of bug 2398 should be fixed, so both Direct3D and OpenGL apps should work fine in windowed mode (except for programs which use their own window rendering code).
Did you run the dlls/user32/tests with your patches applied?
"Roderick Colenbrander" thunderbird2k@gmx.net wrote:
This patch creates an X11 window for the client area. The code is
inspired
by old x11drv of which even a few pieces got copied over. Further Chris Robinson assisted with positioning issues.
After this patch most remnants of bug 2398 should be fixed, so both
Direct3D
and OpenGL apps should work fine in windowed mode (except for programs
which
use their own window rendering code).
Did you run the dlls/user32/tests with your patches applied?
-- Dmitry.
I have tested with a large number of apps but didn't know about this test. I just ran it and all tests run as before except for the 'msg' test but even without the patch it already returns different results each time, so I'm not sure what to think about it.
Below I have attached some of the results.
Roderick
A log without the patch fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f050! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f040! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f040! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f050! msg.c:9307: Test failed: 46: ShowWindow(SW_RESTORE): in msg 0x0047 expecting wParam 0x8120 got 0x8122 msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0003 was expected, but got msg 0x0009 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0005 was expected, but got msg 0x0047 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg sequence is not complete: expected 0000 - actual 0003 msg.c:9307: Test failed: 50: ShowWindow(SW_SHOWNORMAL): in msg 0x0047 expecting wParam 0x8020 got 0x8821 msg.c:7573: Test failed: ScrollWindowEx: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:4034: Test failed: SetWindowPos:WmSWP_ResizeNoZOrder: the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:4034: Test failed: SetWindowPos:WmSWP_ResizeNoZOrder: the msg 0x0005 was expected, but got msg 0x030f instead msg.c:4034: Test failed: SetWindowPos:WmSWP_ResizeNoZOrder: the msg sequence is not complete: expected 0000 - actual 001c fixme:msg:pack_message msg 14 (WM_ERASEBKGND) not supported yet fixme:msg:pack_message msg 14 (WM_ERASEBKGND) not supported yet msg.c:5117: Test failed: WmEmptySeq: the msg sequence is not complete: expected 0000 - actual 0021 msg.c:5125: Test failed: WmEmptySeq: the msg sequence is not complete: expected 0000 - actual 000f msg.c:5273: Test failed: WmParentPaintNc: the msg sequence is not complete: expected 0000 - actual 0021 msg.c:8881: Test failed: WmMouseHoverSeq: the msg 0x0118 was expected, but got msg 0x0046 instead msg.c:8881: Test failed: WmMouseHoverSeq: the msg 0x02a1 was expected, but got msg 0x0047 instead msg.c:8881: Test failed: WmMouseHoverSeq: the msg sequence is not complete: expected 0000 - actual 0003 msg.c:9590: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:10115: Tests skipped: UnhookWinEvent is not available make: *** [msg.ok] Error 16
Run with the patch ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f050! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f040! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f040! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f050! msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): in msg 0x0046 expecting wParam 0x8020 got 0x8120 msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0003 was expected, but got msg 0x0009 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0005 was expected, but got msg 0x0047 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg sequence is not complete: expected 0000 - actual 0003 msg.c:9307: Test failed: 52: ShowWindow(SW_HIDE): in msg 0x0046 expecting wParam 0x83 got 0x93 msg.c:9307: Test failed: 52: ShowWindow(SW_HIDE): in msg 0x0047 expecting wParam 0x1883 got 0x1893 msg.c:9307: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): in msg 0x0047 expecting wParam 0x8170 got 0x8172 msg.c:7573: Test failed: ScrollWindowEx: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:4034: Test failed: SetWindowPos:WmSWP_ResizeNoZOrder: the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:4034: Test failed: SetWindowPos:WmSWP_ResizeNoZOrder: the msg 0x0005 was expected, but got msg 0x030f instead msg.c:4034: Test failed: SetWindowPos:WmSWP_ResizeNoZOrder: the msg sequence is not complete: expected 0000 - actual 001c msg.c:4251: Test failed: DrawMenuBar: the msg sequence is not complete: expected 0000 - actual 000f fixme:msg:pack_message msg 14 (WM_ERASEBKGND) not supported yet msg.c:5094: Test failed: Paint: the msg sequence is not complete: expected 0000 - actual 0014 fixme:msg:pack_message msg 14 (WM_ERASEBKGND) not supported yet msg.c:5273: Test failed: WmParentPaintNc: the msg sequence is not complete: expected 0000 - actual 0021 msg.c:9590: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:10115: Tests skipped: UnhookWinEvent is not available make: *** [msg.ok] Error 15
And another run with the patch ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f050! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f040! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f040! fixme:nonclient:NC_HandleSysCommand unimplemented WM_SYSCOMMAND f050! msg.c:9307: Test failed: 46: ShowWindow(SW_RESTORE): in msg 0x0047 expecting wParam 0x8120 got 0x8122 msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0003 was expected, but got msg 0x0009 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg 0x0005 was expected, but got msg 0x0047 instead msg.c:9307: Test failed: 48: ShowWindow(SW_SHOWMAXIMIZED): the msg sequence is not complete: expected 0000 - actual 0003 msg.c:9307: Test failed: 50: ShowWindow(SW_SHOWNORMAL): in msg 0x0047 expecting wParam 0x8020 got 0x8821 msg.c:7562: Test failed: ScrollWindowEx: the msg 0x000f was expected, but got msg 0x0021 instead msg.c:7562: Test failed: ScrollWindowEx: the msg 0x0014 was expected, but got msg 0x000f instead msg.c:7562: Test failed: ScrollWindowEx: the msg sequence is not complete: expected 0000 - actual 0014 fixme:msg:pack_message msg 14 (WM_ERASEBKGND) not supported yet msg.c:5094: Test failed: Paint: the msg sequence is not complete: expected 0000 - actual 000f fixme:msg:pack_message msg 14 (WM_ERASEBKGND) not supported yet msg.c:5273: Test failed: WmParentPaintNc: the msg sequence is not complete: expected 0000 - actual 0021 msg.c:8881: Test failed: WmMouseHoverSeq: the msg 0x0118 was expected, but got msg 0x0046 instead msg.c:8881: Test failed: WmMouseHoverSeq: the msg 0x02a1 was expected, but got msg 0x0047 instead msg.c:8881: Test failed: WmMouseHoverSeq: the msg sequence is not complete: expected 0000 - actual 0003 msg.c:9590: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:10115: Tests skipped: UnhookWinEvent is not available make: *** [msg.ok] Error 14
-
Dmitry Timoshkov -
Roderick Colenbrander