Regression Bug in Wine MM (Bug #817)

[Ian D. Stewart]

Eric, List,

I have reported what appears to be a regression bug in Wine's 
multimedia subsystem (Bug #817).

When running Baldur's Gate with recent builds of Wine, the game plays 
but without any sound.  Earlier build ran the game with wine.  The last 
known good build from CVS appears to be 2002-05-21 21:45:00 EDT.  This 
looks like it may be related to the patch mmsystem.c commited by 
Alexandre Tue May 21 2002 - 20:52:31 CDT?

I have attached the output from 'wine --debugmsg trace+relay 
Baldur.exe' to the bug report.

Please let me know if there is anything else I can do to assist in 
debugging this.

Ian

[Ian D. Stewart]

On 2002.06.22 14:19 Ian D. Stewart wrote:
> Eric, List,
>
> I have reported what appears to be a regression bug in Wine's 
> multimedia subsystem (Bug #817).

Correction: that should be Bug #818

Ian

[Eric Pouech]

> > I have reported what appears to be a regression bug in Wine's
> > multimedia subsystem (Bug #817).
>
> Correction: that should be Bug #818

does the attached patch cures the regression ?
A+

Name:          ps5
ChangeLog:     fixed flags handling in sndPlaySound
License:       X11
GenDate:       2002/06/23 08:42:11 UTC
ModifiedFiles: dlls/winmm/mmsystem.c
AddedFiles:    
===================================================================
RCS file: /home/cvs/cvsroot/wine/wine/dlls/winmm/mmsystem.c,v
retrieving revision 1.59
diff -u -u -r1.59 mmsystem.c
--- dlls/winmm/mmsystem.c	4 Jun 2002 00:51:38 -0000	1.59
+++ dlls/winmm/mmsystem.c	23 Jun 2002 08:40:22 -0000
@@ -690,7 +690,7 @@
  */
 BOOL WINAPI sndPlaySoundA(LPCSTR pszSoundA, UINT uFlags)
 {
-    uFlags &= ~(SND_ASYNC|SND_LOOP|SND_MEMORY|SND_NODEFAULT|SND_NOSTOP|SND_SYNC);
+    uFlags &= SND_ASYNC|SND_LOOP|SND_MEMORY|SND_NODEFAULT|SND_NOSTOP|SND_SYNC;
     return MULTIMEDIA_PlaySound(pszSoundA, 0, uFlags, FALSE);
 }

@@ -699,7 +699,7 @@
  */
 BOOL WINAPI sndPlaySoundW(LPCWSTR pszSound, UINT uFlags)
 {
-    uFlags &= ~(SND_ASYNC|SND_LOOP|SND_MEMORY|SND_NODEFAULT|SND_NOSTOP|SND_SYNC);
+    uFlags &= SND_ASYNC|SND_LOOP|SND_MEMORY|SND_NODEFAULT|SND_NOSTOP|SND_SYNC;
     return MULTIMEDIA_PlaySound(pszSound, 0, uFlags, TRUE);
 }

[Ian D. Stewart]

On Sunday 23 June 2002 04:43, Eric Pouech wrote:
> > > I have reported what appears to be a regression bug in Wine's
> > > multimedia subsystem (Bug #817).
> >
> > Correction: that should be Bug #818
>
> does the attached patch cures the regression ?
> A+

That did the trick!  Thank you very much.

I noticed that you took ownership of this bug.  I assume you'll handle 
closing the bug?

Thanx Again,
Ian

[Rob Browning]

"Ian D. Stewart"  writes:
> When running Baldur's Gate with recent builds of Wine, the game plays
> but without any sound.  Earlier build ran the game with wine.  The
> last known good build from CVS appears to be 2002-05-21 21:45:00 EDT.
> This looks like it may be related to the patch mmsystem.c commited by
> Alexandre Tue May 21 2002 - 20:52:31 CDT?
>
> I have attached the output from 'wine --debugmsg trace+relay
> Baldur.exe' to the bug report.
>
> Please let me know if there is anything else I can do to assist in
> debugging this.

I recently resurrected Baldur's Gate (with the TOSC add on) and got it
working pretty well here too (thanks all), with the one exception that
as of CVS June 22, it still locks up after playing any movie.  While I
know you can truncate the movie files to get around this, I was
wondering if anyone had an idea what was going on, or if I might be
able to help you debug the problem.

(Also I've been running BGMain.exe -- would it be better to be running
Baldur.exe?)

Thanks

[Ian D. Stewart]

On Wednesday 26 June 2002 23:19, Rob Browning wrote:
> "Ian D. Stewart"  writes:
> > When running Baldur's Gate with recent builds of Wine, the game plays
> > but without any sound.  Earlier build ran the game with wine.  The
> > last known good build from CVS appears to be 2002-05-21 21:45:00 EDT.
> > This looks like it may be related to the patch mmsystem.c commited by
> > Alexandre Tue May 21 2002 - 20:52:31 CDT?
> >
> > I have attached the output from 'wine --debugmsg trace+relay
> > Baldur.exe' to the bug report.
> >
> > Please let me know if there is anything else I can do to assist in
> > debugging this.
>
> I recently resurrected Baldur's Gate (with the TOSC add on) and got it
> working pretty well here too (thanks all), with the one exception that
> as of CVS June 22, it still locks up after playing any movie.

Yeah, I've seen that too.  I have noticed that if you run wine --debugmsg 
trace+relay, Baldur's Gate slows to a crawl, *but* it doesn't lock up after 
playing movies.  Don't know if that helps any developers or not...
> While I
> know you can truncate the movie files to get around this,

How do you do that?
> (Also I've been running BGMain.exe -- would it be better to be running
> Baldur.exe?)

I don't know that there's that much difference, except that with Baldur.exe 
you get the haunting music at the beginning ;)

Ian

[Rob Browning]

"Ian D. Stewart"  writes:
> Yeah, I've seen that too.  I have noticed that if you run wine
> --debugmsg trace+relay, Baldur's Gate slows to a crawl, *but* it
> doesn't lock up after playing movies.  Don't know if that helps any
> developers or not...

Interesting -- wonder if it's timing or a different code path that's
helping there.  In any case I'm happy to help track this down too if I
can.
> > While I know you can truncate the movie files to get around this,
>
> How do you do that?

I believe there are comments in the applications database under either
Baldur's Gate or Baldur's Gate II, but basically, if you've got a lot
of disk space, make a directory, change your .wine/conf to think that
directory is the CD drive, and copy the cd1, cd2, etc. dirs from the
CDs to that directory -- I just do it whenever the game asks for a new
CD, but in that case (if the game's running) make sure you copy to a
tmp name and then rename the directory so the game won't try to use
the dir before it's finished.

Once you've done that, then (for example), after you've seen the
initial movie, you can "mv cd1/movies/moviecd1.bif
cd1/movies/moviecd1.bif.real" and then "touch
cd1/movies/moviecd1.bif".  It won't play the movie again.  That's
about all I know -- I'm not sure whether the above disables that one
movie, or many movies (I'm guessing maybe the latter), and I don't
know where the "resting tent movie" is yet, so that hangs the game
too.

[Eric Pouech]

> with the one exception that
> as of CVS June 22, it still locks up after playing any movie.  While I
> know you can truncate the movie files to get around this, I was
> wondering if anyone had an idea what was going on, or if I might be
> able to help you debug the problem.

hard to tell from here
could you describe the lock up ? I mean, if you wait for a while (at
least
one minute), do you get some extra messages on console ?
A+