Re: shlexec - skip argument identifier

[Vitaliy Margolen]

Oops, resend with the right patch.

Vitaliy Margolen

Wednesday, October 13, 2004, 5:58:22 AM, Vitaliy Margolen wrote:
> Second char of argument identifier was getting into program name:
> wine start http://yahoo.com
> was executing:
> winebrowser "http://yahoo.com%5C%221
> Vitaliy Margolen
> changelog:
>   dlls/shel32/shlexec.com
>   fix parameter parsing

shlexec - skip argument identifier

[Alexandre Julliard]

Vitaliy Margolen  writes:
> --- dlls/shell32/shlexec.c	14 Sep 2004 20:14:09 -0000	1.54
> +++ dlls/shell32/shlexec.c	13 Oct 2004 11:55:04 -0000
> @@ -94,7 +94,8 @@
>      {
>          if (*fmt == '%')
>          {
> -
>        switch (*++fmt)
> -
>    fmt++;
> -
>        switch (*fmt++)
>        {

Incrementing fmt twice here is going to break the rest of the
function, you need to do that at the end.

Re[2]: shlexec - skip argument identifier

[Vitaliy Margolen]

I see it now. I'll work on a better fix. It looks like more things are broken
here.

Wednesday, October 13, 2004, 6:50:45 PM, you wrote:
> Vitaliy Margolen  writes:
> > --- dlls/shell32/shlexec.c	14 Sep 2004 20:14:09 -0000	1.54
> > +++ dlls/shell32/shlexec.c	13 Oct 2004 11:55:04 -0000
> > @@ -94,7 +94,8 @@
> >      {
> >          if (*fmt == '%')
> >          {
> > -
> >        switch (*++fmt)
> > -
> >    fmt++;
> > -
> >        switch (*fmt++)
> >        {
> Incrementing fmt twice here is going to break the rest of the
> function, you need to do that at the end.