word can't open documents...

[Michael Cardenas]

With yesterday's cvs, opening a document causes it to crash with this output 
on the console:

fixme:listview:LISTVIEW_UnsupportedStyles   LVS_SHAREIMAGELISTS
fixme:listview:LISTVIEW_SetItemCount flags LVSICF_NOINVALIDATEALL 
LVSICF_NOSCROLL not implemented
fixme:file:FindFirstChangeNotificationA this is not supported yet 
(non-trivial).
fixme:mpr:WNetGetUniversalNameW (L"Z:\DOS\My Documents\Lkdjs ldkjsdlkj 
sdlkj s.doc", 0x00000001, 0x40552218, 0x4055263c): stub
fixme:mpr:WNetGetUniversalNameW (L"Z:\DOS\My Documents", 0x00000001, 
0x40553d68, 0x4055418c): stub
fixme:mpr:WNetGetUniversalNameW (L"Z:\DOS\My Documents\Lkdjs ldkjsdlkj 
sdlkj s.doc", 0x00000001, 0x4055435c, 0x40554780): stub
fixme:mpr:WNetGetUniversalNameW (L"Z:\DOS\My Documents\Lkdjs ldkjsdlkj 
sdlkj s.doc", 0x00000001, 0x405532b0, 0x405536d4): stub
X Error of failed request:  BadValue (integer parameter out of range for 
operation)
  Major opcode of failed request:  1 (X_CreateWindow)
  Value in failed request:  0x0
  Serial number of failed request:  30392
  Current serial number in output stream:  30395

[Michael Cardenas]

Here's a little more info on this. I ran wine with trace+x11drv and got
this:

trace:x11drv:X11DRV_CreateWindow hwnd 1004a cs 0,0 1022x673
trace:x11drv:X11DRV_CreateWindow win 1004a window 0,0,1022,673 client
0,0,1022,673 whole 0,0,1022,673 X client 0,0,1022,673 xwin
240013f/2400140
X Error of failed request:  BadValue (integer parameter out of range for
operation)
  Major opcode of failed request:  1 (X_CreateWindow)
    Value in failed request:  0x0
      Serial number of failed request:  3077
        Current serial number in output stream:  3080

does anyone know what has changed lately with X11DRV_CreateWindow?

On Wed, Apr 24, 2002 at 04:33:11PM -0400, Michael Cardenas wrote:
> With yesterday's cvs, opening a document causes it to crash with this output 
> on the console:
> X Error of failed request:  BadValue (integer parameter out of range for 
> operation)
>   Major opcode of failed request:  1 (X_CreateWindow)
>   Value in failed request:  0x0
>   Serial number of failed request:  30392
>   Current serial number in output stream:  30395

[Michael Cardenas]

Here's some more info on this major regression in microsoft word, with my own trace
messages added.

This feature works correctly in crossover office, by the way.

The crash occurs after create_whole_window and create_client_window are
called, when we try to do a TSXSync.

----------------------------------------------------------------------

trace:win:WIN_CreateWindowEx (null) "_WwG" ex=00000000 style=46000000
0,0 1022x673 parent=2003f menu=0000 inst=30000000
params=(nil)trace:win:dump_window_styles style: WS_CHILD WS_CLIPSIBLINGS
WS_CLIPCHILDREN
trace:win:dump_window_styles exstyle:
trace:win:WIN_CreateWindowEx winproc type is 2 (WIN_PROC_32A)
trace:win:WIN_SetWindowLong 20040 -12 0 3
trace:x11drv:X11DRV_CreateWindow in
trace:win:WIN_SetRectangles win 20040 window (0,0)-(1022,673) client
(0,0)-(1022,673)
trace:x11drv:X11DRV_CreateWindow before create_whole_window
trace:x11drv:X11DRV_CreateWindow before create_client_window
trace:x11drv:X11DRV_CreateWindow after create_client_window
trace:x11drv:X11DRV_CreateWindow after TSXSync
trace:x11drv:X11DRV_CreateWindow after SetPropA whole_window_atom
trace:x11drv:X11DRV_CreateWindow after SetPropA client_window_atom
trace:x11drv:X11DRV_CreateWindow before WM_GETMINMAXINFO
trace:x11drv:X11DRV_CreateWindow before WM_NCCREATE
trace:x11drv:X11DRV_CreateWindow hwnd 20040 cs 0,0 1022x673
trace:win:WIN_SetRectangles win 20040 window (0,0)-(1022,673) client
(0,0)-(1022,673)
trace:x11drv:X11DRV_CreateWindow win 20040 window 0,0,1022,673 client
0,0,1022,673 whole 0,0,1022,673 X client 0,0,1022,673 xwin
28000ff/2800100
trace:win:WIN_SetWindowLong 20040 0 41e903ec 2
trace:x11drv:X11DRV_CreateWindow returning...
trace:win:WIN_CreateWindowEx created window 20040
trace:win:WIN_CreateWindowEx (null) "SCROLLBAR" ex=00000000
style=54000001 0,1079331068 1065353216x0 parent=2003f menu=0000
inst=30000000 params=(nil)
trace:win:dump_window_styles style: WS_CHILD WS_VISIBLE WS_CLIPSIBLINGS
00000001
trace:win:dump_window_styles exstyle:
trace:win:WIN_CreateWindowEx winproc type is 2 (WIN_PROC_32A)
trace:win:WIN_SetWindowLong 2003c -12 0 3
trace:x11drv:X11DRV_CreateWindow in
trace:win:WIN_SetRectangles win 2003c window
(0,1079331068)-(1065353216,1079331068) client
(0,1079331068)-(1065353216,1079331068)
trace:x11drv:X11DRV_CreateWindow before create_whole_window
trace:x11drv:X11DRV_CreateWindow before create_client_window
trace:x11drv:X11DRV_CreateWindow after create_client_window
X Error of failed request:  BadValue (integer parameter out of range for
operation)
  Major opcode of failed request:  1 (X_CreateWindow)
    Value in failed request:  0x0
      Serial number of failed request:  2275
        Current serial number in output stream:  2278

[Michael Cardenas]

Is anyone else even seeing this behavior on their machine?

On Tue, Apr 30, 2002 at 02:15:18PM -0400, Michael Cardenas wrote:
> Here's some more info on this major regression in microsoft word, with my own trace
> messages added.
>
> This feature works correctly in crossover office, by the way.
>
> The crash occurs after create_whole_window and create_client_window are
> called, when we try to do a TSXSync.

...
> trace:x11drv:X11DRV_CreateWindow after create_client_window
> X Error of failed request:  BadValue (integer parameter out of range for
> operation)
>   Major opcode of failed request:  1 (X_CreateWindow)
>     Value in failed request:  0x0
>       Serial number of failed request:  2275
>         Current serial number in output stream:  2278

help with word (was:Re: word can't open documents...)

[Michael Cardenas]

Does anyone know how an app determines the size it's scrollbar should
be? I think it is done with either the GetDeviceCaps or something in the
DC(?)

In crossover office, when word tries to open a document it tries to
create a window with class SCROLLBAR of size 16x0, and the document
opens fine.

In the public tree, when word tries to open a document, it tries to
create a SCROLLBAR window of size 1065353216x0, and X barfs and word
crashes.

Running with +relay, the window has the size 981316x0 and the document
opens fine.

If anyone has any pointers here, I'd really appreciate it.

thanks
      michael

On Wed, May 01, 2002 at 09:15:18AM -0400, Michael Cardenas wrote:
> On Tue, Apr 30, 2002 at 02:15:18PM -0400, Michael Cardenas wrote:
> > Here's some more info on this major regression in microsoft word, with my own trace
> > messages added.
> >
> > This feature works correctly in crossover office, by the way.
> >
> > The crash occurs after create_whole_window and create_client_window are
> > called, when we try to do a TSXSync.
>
> ...
> > trace:x11drv:X11DRV_CreateWindow after create_client_window
> > X Error of failed request:  BadValue (integer parameter out of range for
> > operation)
> >   Major opcode of failed request:  1 (X_CreateWindow)
> >     Value in failed request:  0x0
> >       Serial number of failed request:  2275
> >         Current serial number in output stream:  2278

help with word (was:Re: word can't open documents...)

[Michael Cardenas]

I have a fix for this bug, but it just handles the current erroneous
behavior, it doesn't get fix the real cause of the bug. So, other apps
might have problems getting the proper size for their scrollbars still.

Attached is a patch that adds a sanity check to the x11drv so that we
never try to create windows that will cause the X server to stop and
wine to crash.

Tomorrow, I'll find the real maximum values in the X11 source.

I know this does not fix the real cause of the problem, but it does fix
a crash in wine.

On Wed, May 01, 2002 at 03:32:45PM -0400, Michael Cardenas wrote:
> Does anyone know how an app determines the size it's scrollbar should
> be? I think it is done with either the GetDeviceCaps or something in the
> DC(?)
>
> In crossover office, when word tries to open a document it tries to
> create a window with class SCROLLBAR of size 16x0, and the document
> opens fine.
>
> In the public tree, when word tries to open a document, it tries to
> create a SCROLLBAR window of size 1065353216x0, and X barfs and word
> crashes.
>
> Running with +relay, the window has the size 981316x0 and the document
> opens fine.
>
> If anyone has any pointers here, I'd really appreciate it.
>
> thanks
>       michael
>
> On Wed, May 01, 2002 at 09:15:18AM -0400, Michael Cardenas wrote:
> > > This feature works correctly in crossover office, by the way.

...
> > > The crash occurs after create_whole_window and create_client_window are
> > > called, when we try to do a TSXSync.
> >
> > ...
> > > trace:x11drv:X11DRV_CreateWindow after create_client_window
> > > X Error of failed request:  BadValue (integer parameter out of range for
> > > operation)
> > >   Major opcode of failed request:  1 (X_CreateWindow)
> > >     Value in failed request:  0x0
> > >       Serial number of failed request:  2275
> > >         Current serial number in output stream:  2278