Re: shell32/tests: Add test for SHFileOperation [resend]

[James Hawkins]

2008/6/28 Vitaly Perov :
> Changelog:
> - shell32/tests: Add test for SHFileOperation

+    /* move many files into directory with FOF_MULTIDESTFILES */
+    set_curr_dir_path(from, "test?.txt\0");
+    set_curr_dir_path(to, "testdir2\0");
+    retval = SHFileOperationA(&shfo2);

You didn't set the FOF_MULTIDESTFILES flag.

shell32/tests: Add test for SHFileOperation [resend]

[Vitaly Perov]

> You didn't set the FOF_MULTIDESTFILES flag.

I use &shfo2. In shfo2 this flag is always set.

shell32/tests: Add test for SHFileOperation [resend]

[James Hawkins]

On Sun, Jun 29, 2008 at 5:16 AM, Vitaly Perov  wrote:
> > You didn't set the FOF_MULTIDESTFILES flag.
>
> I use &shfo2. In shfo2 this flag is always set.

Don't make assumptions in the tests; it makes them harder to read.
Why don't you put the test right below the exact same test that
doesn't have the FOF_MULTIDESTFILES flag set (like I said before)?
It's more logical and shows exactly what behavior you're comparing in
the tests.