On 11/26/12 8:42 PM, Andrew Talbot wrote:
Changelog: msvcp60: Remove superfluous semicolons.
diff --git a/dlls/msvcp60/exception.c b/dlls/msvcp60/exception.c index 761075e..b8c6921 100644 --- a/dlls/msvcp60/exception.c +++ b/dlls/msvcp60/exception.c @@ -137,7 +137,7 @@ void * __thiscall MSVCP_exception_vector_dtor(exception *this, unsigned int flag }
DEFINE_RTTI_DATA0(exception, 0, ".?AVexception@std@@"); -DEFINE_CXX_DATA0(exception, MSVCP_exception_dtor); +DEFINE_CXX_DATA0(exception, MSVCP_exception_dtor)
It's probably better to change the macro to require the semicolon.
Jacek
Jacek Caban wrote:
It's probably better to change the macro to require the semicolon.
Jacek
The reason I did it that way was because there are two variants of the DEFINE_CXX_DATA macro, surrounded by an #ifndef construct: one comprising three struct declarations, all ending in semicolons, the other comprised three struct declarations (ending in semicolons) and one function definition (ending in a curly brace). I suppose I could move the function above the structs, but that would require forward declarations.
On 11/26/12 22:35, Andrew Talbot wrote:
Jacek Caban wrote:
It's probably better to change the macro to require the semicolon.
Jacek
The reason I did it that way was because there are two variants of the DEFINE_CXX_DATA macro, surrounded by an #ifndef construct: one comprising three struct declarations, all ending in semicolons, the other comprised three struct declarations (ending in semicolons) and one function definition (ending in a curly brace). I suppose I could move the function above the structs, but that would require forward declarations.
Ah, sorry, missed the function there. Both solution seem equally fine then.
Jacek
-
Andrew Talbot -
Jacek Caban