Re: kernel32: add a stub for CancelSynchronousIo

[Dmitry Timoshkov]

Austin English  wrote:
> +BOOL WINAPI CancelSynchronousIo(HANDLE thread)
> +{
> - FIXME("(%p): stub\n", thread);
> - SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> - return FALSE;
>
> +}

...
> +@ stdcall CancelSynchronousIo(ptr)

Please have a look at other .spec file entries how a thread handle (or HANDLE
in general) is supposed to be represented.

kernel32: add a stub for CancelSynchronousIo

[Austin English]

On Mon, Oct 12, 2015 at 8:15 PM, Dmitry Timoshkov  wrote:
> Austin English  wrote:
> > +BOOL WINAPI CancelSynchronousIo(HANDLE thread)
> > +{
> > - FIXME("(%p): stub\n", thread);
> > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> > - return FALSE;
> >
> > +}
>
> ...
> > +@ stdcall CancelSynchronousIo(ptr)
>
> Please have a look at other .spec file entries how a thread handle (or HANDLE
> in general) is supposed to be represented.
>
> --
> Dmitry.

Thanks for the tip, though it appears that several functions have this
wrong. E.g.,
kernel32.spec:@ stdcall FindVolumeClose(ptr)
kernel32.spec:@ stdcall FindVolumeMountPointClose(ptr)
volume.c:BOOL WINAPI FindVolumeClose(HANDLE handle)
volume.c:BOOL WINAPI FindVolumeMountPointClose(HANDLE h)

Anyway, I'll send a fixed version. Thanks for reviewing.

kernel32: add a stub for CancelSynchronousIo

[Nikolay Sivov]

On 13.10.2015 12:12, Austin English wrote:
> On Mon, Oct 12, 2015 at 8:15 PM, Dmitry Timoshkov  wrote:
> > Austin English  wrote:
> > > +BOOL WINAPI CancelSynchronousIo(HANDLE thread)
> > > +{
> > > - FIXME("(%p): stub\n", thread);
> > > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> > > - return FALSE;
> > >
> > > +}
> >
> > ...
> > > +@ stdcall CancelSynchronousIo(ptr)
> >
> > Please have a look at other .spec file entries how a thread handle (or HANDLE
> > in general) is supposed to be represented.
> >
> > --
> > Dmitry.
>
> Thanks for the tip, though it appears that several functions have this
> wrong. E.g.,
> kernel32.spec:@ stdcall FindVolumeClose(ptr)
> kernel32.spec:@ stdcall FindVolumeMountPointClose(ptr)
> volume.c:BOOL WINAPI FindVolumeClose(HANDLE handle)
> volume.c:BOOL WINAPI FindVolumeMountPointClose(HANDLE h)

In practice it means no difference if it's ptr or long for HANDLEs. But 
I guess for consistency it's definitely better to use 'long'.
> Anyway, I'll send a fixed version. Thanks for reviewing.