Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)

[Paul Vriens]

On 07/29/2011 01:29 AM, Octavian Voicu wrote:
> - else
> -
>    win_skip("Not on WOW64, skipping test.\n");

Why a win_skip()? Isn't a normal skip() more appropriate?

[PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)

[Octavian Voicu]

On Fri, Jul 29, 2011 at 9:55 AM, Paul Vriens  wrote:
> > - win_skip("Not on WOW64, skipping test.\n");
>
> Why a win_skip()? Isn't a normal skip() more appropriate?

Year, you're right, win_skip didn't make much sense. I was only
thinking at GetSystemWow64DirectoryW when I wrote that (which, is
always implemented on Wine); forgot about the is_wow64 part. Thanks
for the feedback!

I see Alexandre committed it without the win_skip part, so it's probably better.

Octavian